starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #150] [MERGED] Fix shared nodes #1289

New Issue
Closed
opened 2025-12-29 02:29:34 +01:00 by adam · 0 comments
adam commented 2025-12-29 02:29:34 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/150
Author: @juanfont
Created: 10/12/2021
Status: ✅ Merged
Merged: 10/16/2021
Merged by: @juanfont

Base: main ← Head: fix-shared-nodes

📝 Commits (8)

  • fa8cd96 Get peers from namespaces where shared nodes are shared to
  • ebfb8c8 Fix tests, as IDs of Machines where wrongly starting in 0
  • 6aa763a Expanded unit tests to better cover sharing nodes
  • 6c4c761 Merge branch 'main' into fix-shared-nodes
  • 3e1e07e Fixed integration tests for shared nodes
  • 9f52a64 Merge branch 'main' into fix-shared-nodes
  • be36480 Reverted back values in integration tests
  • d0daff1 Added TODO in waiting

📊 Changes

3 files changed (+99 additions, -51 deletions)

View changed files

📝 integration_test.go (+37 -37)
📝 machine.go (+44 -2)
📝 sharing_test.go (+18 -12)

📄 Description

This PR exposes to a shared node the peers from the namespaces where it is shared to.

This is rather shameful. Shared nodes should have never worked without this.

This PR is not to be merged yet. Needs integrations tests.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/150 **Author:** [@juanfont](https://github.com/juanfont) **Created:** 10/12/2021 **Status:** ✅ Merged **Merged:** 10/16/2021 **Merged by:** [@juanfont](https://github.com/juanfont) **Base:** `main` ← **Head:** `fix-shared-nodes` --- ### 📝 Commits (8) - [`fa8cd96`](https://github.com/juanfont/headscale/commit/fa8cd96108d4e71e2c499469046f5fb22a3cdda2) Get peers from namespaces where shared nodes are shared to - [`ebfb8c8`](https://github.com/juanfont/headscale/commit/ebfb8c8c5ee512fec956b325aeca03d93b4619dd) Fix tests, as IDs of Machines where wrongly starting in 0 - [`6aa763a`](https://github.com/juanfont/headscale/commit/6aa763a1ae3e9063c901385d5a405b50ce79c9e5) Expanded unit tests to better cover sharing nodes - [`6c4c761`](https://github.com/juanfont/headscale/commit/6c4c7614088f60affc949d549fb07976cf9d3a83) Merge branch 'main' into fix-shared-nodes - [`3e1e07e`](https://github.com/juanfont/headscale/commit/3e1e07e8c153517155beb727b5be4cec2c1e9903) Fixed integration tests for shared nodes - [`9f52a64`](https://github.com/juanfont/headscale/commit/9f52a64a6a08b002c83c0ae745b5a1dcf080077b) Merge branch 'main' into fix-shared-nodes - [`be36480`](https://github.com/juanfont/headscale/commit/be36480a64770ff508aafe1f72a267fa2c8d3dc9) Reverted back values in integration tests - [`d0daff1`](https://github.com/juanfont/headscale/commit/d0daff180e82db621189d6916595535d2ebc06f1) Added TODO in waiting ### 📊 Changes **3 files changed** (+99 additions, -51 deletions) <details> <summary>View changed files</summary> 📝 `integration_test.go` (+37 -37) 📝 `machine.go` (+44 -2) 📝 `sharing_test.go` (+18 -12) </details> ### 📄 Description This PR exposes to a shared node the peers from the namespaces where it is shared to. This is rather shameful. Shared nodes should have never worked without this. This PR is not to be merged yet. Needs integrations tests. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 02:29:34 +01:00
adam closed this issue 2025-12-29 02:29:34 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#1289
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?