starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #147] [MERGED] Fix error 500 when deleting a shared node #1286

New Issue
Closed
opened 2025-12-29 02:29:34 +01:00 by adam · 0 comments
adam commented 2025-12-29 02:29:34 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/147
Author: @juanfont
Created: 10/10/2021
Status: ✅ Merged
Merged: 10/11/2021
Merged by: @juanfont

Base: main ← Head: fix-delete-shared-nodes

📝 Commits (2)

📊 Changes

3 files changed (+150 additions, -0 deletions)

View changed files

📝 machine.go (+11 -0)
📝 sharing.go (+11 -0)
📝 sharing_test.go (+128 -0)

📄 Description

This PR adds an extra step when deleting nodes to also delete the SharedMachine relation (used to shared nodes across namespaces).

Fixes #133.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/147 **Author:** [@juanfont](https://github.com/juanfont) **Created:** 10/10/2021 **Status:** ✅ Merged **Merged:** 10/11/2021 **Merged by:** [@juanfont](https://github.com/juanfont) **Base:** `main` ← **Head:** `fix-delete-shared-nodes` --- ### 📝 Commits (2) - [`48f5a9a`](https://github.com/juanfont/headscale/commit/48f5a9a18c1ffc33a9be31d8f26b384c267f336f) Fix error 500 when deleting shared node (fixes #133) - [`7f2027d`](https://github.com/juanfont/headscale/commit/7f2027d7f23039c0ce8aade9f1951dc283091601) Added unit tests ### 📊 Changes **3 files changed** (+150 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `machine.go` (+11 -0) 📝 `sharing.go` (+11 -0) 📝 `sharing_test.go` (+128 -0) </details> ### 📄 Description This PR adds an extra step when deleting nodes to also delete the `SharedMachine` relation (used to shared nodes across namespaces). Fixes #133. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 02:29:34 +01:00
adam closed this issue 2025-12-29 02:29:34 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#1286
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?