starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #82] [MERGED] Also notify peers when deleting ephemerals #1245

New Issue
Closed
opened 2025-12-29 02:29:26 +01:00 by adam · 0 comments
adam commented 2025-12-29 02:29:26 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/82
Author: @juanfont
Created: 8/12/2021
Status: ✅ Merged
Merged: 8/12/2021
Merged by: @juanfont

Base: main ← Head: really-expire-ephemeral

📝 Commits (4)

  • 4c84953 Expire the ephemeral nodes in the Serve method
  • c1e6157 Expire ephemeral is internal
  • ab61c87 Also notify peers when deleting ephemerals
  • 8eb7d47 Fixed linting

📊 Changes

4 files changed (+34 additions, -21 deletions)

View changed files

📝 app.go (+7 -2)
📝 cmd/headscale/cli/server.go (+1 -1)
📝 machine.go (+23 -0)
📝 namespaces.go (+3 -18)

📄 Description

As reported by @viq on Twitter, ephemeral nodes are being deleted, but the changes are not notified to their former peers.

This PR addresses that.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/82 **Author:** [@juanfont](https://github.com/juanfont) **Created:** 8/12/2021 **Status:** ✅ Merged **Merged:** 8/12/2021 **Merged by:** [@juanfont](https://github.com/juanfont) **Base:** `main` ← **Head:** `really-expire-ephemeral` --- ### 📝 Commits (4) - [`4c84953`](https://github.com/juanfont/headscale/commit/4c849539fc672b72e9e992db017f0bab2106020e) Expire the ephemeral nodes in the Serve method - [`c1e6157`](https://github.com/juanfont/headscale/commit/c1e61578475f392e1fbe30236c2837e10e63fedf) Expire ephemeral is internal - [`ab61c87`](https://github.com/juanfont/headscale/commit/ab61c877019475d59fe0c8437cea539fca63af94) Also notify peers when deleting ephemerals - [`8eb7d47`](https://github.com/juanfont/headscale/commit/8eb7d47072cb2c39ba9595668688f24b1f561d86) Fixed linting ### 📊 Changes **4 files changed** (+34 additions, -21 deletions) <details> <summary>View changed files</summary> 📝 `app.go` (+7 -2) 📝 `cmd/headscale/cli/server.go` (+1 -1) 📝 `machine.go` (+23 -0) 📝 `namespaces.go` (+3 -18) </details> ### 📄 Description As reported by @viq on Twitter, ephemeral nodes are being deleted, but the changes are not notified to their former peers. This PR addresses that. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 02:29:26 +01:00
adam closed this issue 2025-12-29 02:29:26 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#1245
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?