starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #77] [MERGED] Remove more deadlocks #1242

New Issue
Closed
opened 2025-12-29 02:29:25 +01:00 by adam · 0 comments
adam commented 2025-12-29 02:29:25 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/77
Author: @kradalby
Created: 8/6/2021
Status: ✅ Merged
Merged: 8/7/2021
Merged by: @juanfont

Base: main ← Head: deadlierlocks

📝 Commits (4)

📊 Changes

3 files changed (+3 additions, -11 deletions)

View changed files

📝 api.go (+3 -8)
📝 app.go (+0 -1)
📝 routes.go (+0 -2)

📄 Description

This PR removes more deadlocks, one I forgot and on (from keepAlive) that I could not understand why was there.

Ideally we need some wireup tests to test for locks and check actual tailscale(d) behaviour over time.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/77 **Author:** [@kradalby](https://github.com/kradalby) **Created:** 8/6/2021 **Status:** ✅ Merged **Merged:** 8/7/2021 **Merged by:** [@juanfont](https://github.com/juanfont) **Base:** `main` ← **Head:** `deadlierlocks` --- ### 📝 Commits (4) - [`5bc5c5d`](https://github.com/juanfont/headscale/commit/5bc5c5dc1bc55e5e2d6ceff4bc289884ab01e7bb) Remove forgotten lock - [`4243885`](https://github.com/juanfont/headscale/commit/4243885246d1ac475ed46437d0729ff276f57344) Rewrite old lock error msg - [`15b8c8f`](https://github.com/juanfont/headscale/commit/15b8c8f4c5b43a21a8ae46171a0a05241d96f9c8) Remove lock from keepAlive - [`99fd126`](https://github.com/juanfont/headscale/commit/99fd126219c1d2a0528cc08449470c07d5f68ff9) Remove unused mutex ### 📊 Changes **3 files changed** (+3 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `api.go` (+3 -8) 📝 `app.go` (+0 -1) 📝 `routes.go` (+0 -2) </details> ### 📄 Description This PR removes more deadlocks, one I forgot and on (from keepAlive) that I could not understand why was there. Ideally we need some wireup tests to test for locks and check actual tailscale(d) behaviour over time. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 02:29:25 +01:00
adam closed this issue 2025-12-29 02:29:25 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#1242
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?