starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-13 04:40:29 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #54] [MERGED] Implement node deletion #1227

New Issue
Closed
opened 2025-12-29 02:29:17 +01:00 by adam · 0 comments
adam commented 2025-12-29 02:29:17 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/54
Author: @juanfont
Created: 7/17/2021
Status: ✅ Merged
Merged: 7/19/2021
Merged by: @juanfont

Base: main ← Head: delete-nodes

📝 Commits (6)

  • f3139d2 Added methods to delete nodes
  • 9ca2ae7 Implemented delete nodes (#52)
  • 39b756c Fixed linting
  • 0f649aa Ask for confirmation before deleting
  • 96b4d2f Mark the machine as unregistered before soft delete
  • 57c115e Fix linting error:

📊 Changes

6 files changed (+166 additions, -2 deletions)

View changed files

📝 cmd/headscale/cli/nodes.go (+48 -2)
📝 cmd/headscale/headscale.go (+1 -0)
📝 go.mod (+1 -0)
📝 go.sum (+18 -0)
📝 machine.go (+27 -0)
📝 machine_test.go (+71 -0)

📄 Description

This PR adds the subcommand to (soft) delete nodes from the headscale DB.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/54 **Author:** [@juanfont](https://github.com/juanfont) **Created:** 7/17/2021 **Status:** ✅ Merged **Merged:** 7/19/2021 **Merged by:** [@juanfont](https://github.com/juanfont) **Base:** `main` ← **Head:** `delete-nodes` --- ### 📝 Commits (6) - [`f3139d2`](https://github.com/juanfont/headscale/commit/f3139d26c87ca0bbcda014e9ecc6fe1734bcfab0) Added methods to delete nodes - [`9ca2ae7`](https://github.com/juanfont/headscale/commit/9ca2ae7fc5c9b58d7024372ff1a4c8358b5f4fed) Implemented delete nodes (#52) - [`39b756c`](https://github.com/juanfont/headscale/commit/39b756cf5548535e23ecc5b71592dc000e6f2d06) Fixed linting - [`0f649aa`](https://github.com/juanfont/headscale/commit/0f649aae8b43ad934057b353a6caaf1ade2167ad) Ask for confirmation before deleting - [`96b4d2f`](https://github.com/juanfont/headscale/commit/96b4d2f391943ef6a5659e28a3fa68e53adb2644) Mark the machine as unregistered before soft delete - [`57c115e`](https://github.com/juanfont/headscale/commit/57c115e60a40a380613dd95175eae42a5635d514) Fix linting error: ### 📊 Changes **6 files changed** (+166 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `cmd/headscale/cli/nodes.go` (+48 -2) 📝 `cmd/headscale/headscale.go` (+1 -0) 📝 `go.mod` (+1 -0) 📝 `go.sum` (+18 -0) 📝 `machine.go` (+27 -0) 📝 `machine_test.go` (+71 -0) </details> ### 📄 Description This PR adds the subcommand to (soft) delete nodes from the headscale DB. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 02:29:17 +01:00
adam closed this issue 2025-12-29 02:29:17 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#1227
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?