[PR #11] [MERGED] fix: remove db twice #1194

New Issue

adam · 2025-12-29T02:29:11+01:00

adam commented

2025-12-29 02:29:11 +01:00

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/11
Author: @xpzouying
Created: 4/24/2021
Status: ✅ Merged
Merged: 4/25/2021
Merged by: @juanfont

Base: main ← Head: zy/fix-remove-dup-close-db

📝 Commits (1)

07a9f95 fix: remove db twice

📊 Changes

1 file changed (+3 additions, -2 deletions)

View changed files

📝 cli.go (+3 -2)

📄 Description

fix: remove db twice.
better for new error, use errors.New.
Error strings should not be capitalized or end with punctuation.
https://github.com/golang/go/wiki/CodeReviewComments#error-strings

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/11 **Author:** [@xpzouying](https://github.com/xpzouying) **Created:** 4/24/2021 **Status:** ✅ Merged **Merged:** 4/25/2021 **Merged by:** [@juanfont](https://github.com/juanfont) **Base:** `main` ← **Head:** `zy/fix-remove-dup-close-db` --- ### 📝 Commits (1) - [`07a9f95`](https://github.com/juanfont/headscale/commit/07a9f95aeb2d124bff2434f8535fe5c271bb7ed7) fix: remove db twice ### 📊 Changes **1 file changed** (+3 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `cli.go` (+3 -2) </details> ### 📄 Description * fix: remove db twice. * better for new error, use errors.New. * Error strings should not be capitalized or end with punctuation. https://github.com/golang/go/wiki/CodeReviewComments#error-strings --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-29 02:29:11 +01:00

adam closed this issue

2025-12-29 02:29:11 +01:00

adam referenced this issue

2025-12-29 03:19:00 +01:00

[PR #1194] [CLOSED] docs(README): update contributors #1953

Sign in to join this conversation.

Branches Tags

main

update_flake_lock_action

gh-pages

kradalby/release-v0.27.2

dependabot/go_modules/golang.org/x/crypto-0.45.0

dependabot/go_modules/github.com/opencontainers/runc-1.3.3

copilot/investigate-headscale-issue-2788

copilot/investigate-visibility-issue-2788

copilot/investigate-issue-2833

copilot/debug-issue-2846

copilot/fix-issue-2847

dependabot/go_modules/github.com/go-viper/mapstructure/v2-2.4.0

dependabot/go_modules/github.com/docker/docker-28.3.3incompatible

kradalby/cli-experiement3

doc/0.26.1

doc/0.25.1

doc/0.25.0

doc/0.24.3

doc/0.24.2

doc/0.24.1

doc/0.24.0

kradalby/build-docker-on-pr

topic/docu-versioning

topic/docker-kos

juanfont/fix-crash-node-id

juanfont/better-disclaimer

update-contributors

topic/prettier

revert-1893-add-test-stage-to-docs

add-test-stage-to-docs

remove-node-check-interval

fix-empty-prefix

fix-ephemeral-reusable

bug_report-debuginfo

autogroups

logs-to-stderr

revert-1414-topic/fix_unix_socket

rename-machine-node

port-embedded-derp-tests-v2

port-derp-tests

duplicate-word-linter

update-tailscale-1.36

warn-against-apache

ko-fi-link

more-acl-tests

fix-typo-standalone

parallel-nolint

tparallel-fix

rerouting

ssh-changelog-docs

oidc-cleanup

web-auth-flow-tests

kradalby-gh-runner

fix-proto-lint

remove-funding-links

go-1.19

enable-1.30-in-tests

0.16.x

cosmetic-changes-integration

tmp-fix-integration-docker

fix-integration-docker

configurable-update-interval

show-nodes-online

hs2021

acl-syntax-fixes

ts2021-implementation

fix-spurious-updates

unstable-integration-tests

mandatory-stun

embedded-derp

prtemplate-fix

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/headscale#1194