starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

New hosts are not computed in ACL's #117

New Issue
Closed
opened 2025-12-29 01:23:28 +01:00 by adam · 1 comment
adam commented 2025-12-29 01:23:28 +01:00
Owner
Copy Link

Originally created by @restanrm on GitHub (Feb 2, 2022).

The function generateACLRules is called only once and at the startup of the headscale serve command. The issue is that the ACL's are transformed into a Policy (Golang structured data) and then into aclRules with the generateACLRules. This functions role is to transform users, groups and tags to SrcIPs and DestPorts in these ACLRules. This should be applied each time a new host is added, because else it will not be included in the filters later. This is also true when the host is modified to add (or remove) a tag.

Originally created by @restanrm on GitHub (Feb 2, 2022). The function `generateACLRules` is called only once and at the startup of the `headscale serve` command. The issue is that the ACL's are transformed into a Policy (Golang structured data) and then into `aclRules` with the `generateACLRules`. This functions role is to transform `users`, `groups` and `tags` to `SrcIPs` and `DestPorts` in these ACLRules. This should be applied each time a new host is added, because else it will not be included in the filters later. This is also true when the host is modified to add (or remove) a tag.
adam added the bug label 2025-12-29 01:23:28 +01:00
adam closed this issue 2025-12-29 01:23:28 +01:00
adam commented 2025-12-29 01:23:29 +01:00
Author
Owner
Copy Link

@restanrm commented on GitHub (Mar 7, 2022):

This bug should have been fixed with the modifications made here 435ee36d78/poll.go (L92-L101) introduced in commit 97eac3b938 and improved later

@restanrm commented on GitHub (Mar 7, 2022): This bug should have been fixed with the modifications made here https://github.com/juanfont/headscale/blob/435ee36d789995553150991404a38d3403e0c1d8/poll.go#L92-L101 introduced in commit https://github.com/juanfont/headscale/commit/97eac3b9389e5eb17dc901f15bdb4882d0e7a167 and improved later
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#117
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?