starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

TestShuffleDERPMapDeterministic is flaky #1132

New Issue
Closed
opened 2025-12-29 02:28:28 +01:00 by adam · 0 comments
adam commented 2025-12-29 02:28:28 +01:00
Owner
Copy Link

Originally created by @kradalby on GitHub (Nov 1, 2025).

TestShuffleDERPMapDeterministic is suppose to use the fixed seed based on a base name, but the test is flaky on CI (not locally).

This is getting annoying and needs to be investigated.

=== FAIL: hscontrol/derp TestShuffleDERPMapDeterministic/multiple_regions_with_nodes (0.00s)
    derp_test.go:184: Shuffled DERP map doesn't match expected (-expected +actual):
          &tailcfg.DERPMap{
          	HomeParams: nil,
          	Regions: map[int]*tailcfg.DERPRegion{
          		2: &{
          			... // 5 identical fields
          			Avoid:           false,
          			NoMeasureNoHome: false,
          			Nodes: []*tailcfg.DERPNode{
          				&{
        - 					Name:     "2f",
        + 					Name:     "2d",
          					RegionID: 2,
        - 					HostName: "derp2f.tailscale.com",
        + 					HostName: "derp2d.tailscale.com",
          					CertName: "",
          					IPv4:     "",
          					... // 7 identical fields
          				},
          				&{Name: "2e", RegionID: 2, HostName: "derp2e.tailscale.com"},
          				&{
        - 					Name:     "2d",
        + 					Name:     "2f",
          					RegionID: 2,
        - 					HostName: "derp2d.tailscale.com",
        + 					HostName: "derp2f.tailscale.com",
          					CertName: "",
          					IPv4:     "",
          					... // 7 identical fields
          				},
          			},
          		},
          		10: &{
          			... // 5 identical fields
          			Avoid:           false,
          			NoMeasureNoHome: false,
          			Nodes: []*tailcfg.DERPNode{
          				&{
        - 					Name:     "10b",
        + 					Name:     "10d",
          					RegionID: 10,
        - 					HostName: "derp10b.tailscale.com",
        + 					HostName: "derp10d.tailscale.com",
          					CertName: "",
          					IPv4:     "",
          					... // 7 identical fields
          				},
          				&{Name: "10c", RegionID: 10, HostName: "derp10c.tailscale.com"},
          				&{
        - 					Name:     "10d",
        + 					Name:     "10b",
          					RegionID: 10,
        - 					HostName: "derp10d.tailscale.com",
        + 					HostName: "derp10b.tailscale.com",
          					CertName: "",
          					IPv4:     "",
          					... // 7 identical fields
          				},
          			},
          		},
          	},
          	OmitDefaultRegions: false,
          }
Originally created by @kradalby on GitHub (Nov 1, 2025). TestShuffleDERPMapDeterministic is suppose to use the fixed seed based on a base name, but the test is flaky on CI (not locally). This is getting annoying and needs to be investigated. ``` === FAIL: hscontrol/derp TestShuffleDERPMapDeterministic/multiple_regions_with_nodes (0.00s) derp_test.go:184: Shuffled DERP map doesn't match expected (-expected +actual): &tailcfg.DERPMap{ HomeParams: nil, Regions: map[int]*tailcfg.DERPRegion{ 2: &{ ... // 5 identical fields Avoid: false, NoMeasureNoHome: false, Nodes: []*tailcfg.DERPNode{ &{ - Name: "2f", + Name: "2d", RegionID: 2, - HostName: "derp2f.tailscale.com", + HostName: "derp2d.tailscale.com", CertName: "", IPv4: "", ... // 7 identical fields }, &{Name: "2e", RegionID: 2, HostName: "derp2e.tailscale.com"}, &{ - Name: "2d", + Name: "2f", RegionID: 2, - HostName: "derp2d.tailscale.com", + HostName: "derp2f.tailscale.com", CertName: "", IPv4: "", ... // 7 identical fields }, }, }, 10: &{ ... // 5 identical fields Avoid: false, NoMeasureNoHome: false, Nodes: []*tailcfg.DERPNode{ &{ - Name: "10b", + Name: "10d", RegionID: 10, - HostName: "derp10b.tailscale.com", + HostName: "derp10d.tailscale.com", CertName: "", IPv4: "", ... // 7 identical fields }, &{Name: "10c", RegionID: 10, HostName: "derp10c.tailscale.com"}, &{ - Name: "10d", + Name: "10b", RegionID: 10, - HostName: "derp10d.tailscale.com", + HostName: "derp10b.tailscale.com", CertName: "", IPv4: "", ... // 7 identical fields }, }, }, }, OmitDefaultRegions: false, } ```
adam closed this issue 2025-12-29 02:28:28 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#1132
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?