mirror of
https://github.com/juanfont/headscale.git
synced 2026-01-11 20:00:28 +01:00
[Bug] Any DB error on getting node during serving stream updates leads to panic and further delays #1066
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @vaskravchuk on GitHub (Jul 19, 2025).
if it's not possible to get node:
7fce5065c4/hscontrol/poll.go (L260C4-L265C5)m.node will be nil.
which leads to panic in defer function:
7fce5065c4/hscontrol/poll.go (L182C34-L182C45)as not possible to get ID from nil node
panic is recovered by http2 code but it leads to the state that node is not removed from notifier. So each call to "notifyall" brings delays, and performance degradation
@vaskravchuk commented on GitHub (Jul 19, 2025):
possible the reason(partially) of next bug #2192
and #2597
@kradalby commented on GitHub (Sep 10, 2025):
This got moved around and should not happen after #2670