starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-14 13:13:30 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[Bug] Nodes Reported as Offline when Updating Routes #1039

New Issue
Closed
opened 2025-12-29 02:27:52 +01:00 by adam · 2 comments
adam commented 2025-12-29 02:27:52 +01:00
Owner
Copy Link

Originally created by @GoodiesHQ on GitHub (May 30, 2025).

Is this a support request?

  • This is not a support request

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

When sending a POST request to /api/v1/node/<NodeID>/approved_routes, the response is the node object

    "v1SetApprovedRoutesResponse": {
      "type": "object",
      "properties": {
        "node": {
          "$ref": "#/definitions/v1Node"
        }
      }
    },

However, it seems like no matter what the status is of the node before-hand, it will always be reported as online: false within the response's node object.

The node is online, then approve_routes displays the status as offline, then immediately shows online again.

Expected Behavior

The status of the node should not change.

Steps To Reproduce

Forgive me for using the annoying escape mechanics of windows powershell, but I can run this compound command. It checks a node and uses jq to parse the ".node.online" value. It returns true. Then it updates the node's approved routes, and prints out the same ".node.online" value. Finally, it performs the first request again just to check the node's true online status.

PS C:\> 
>> curl.exe -s -H "Authorization: Bearer ${TOKEN}" https://headscale.example.com/api/v1/node/8 | jq .node.online;
>> curl.exe -s -H "Authorization: Bearer ${TOKEN}" -X POST -d "{\`"routes\`":[\`"192.168.0.0/16\`"]}" https://headscale.example.com/api/v1/node/8/approve_routes | jq .node.online;
>> curl.exe -s -H "Authorization: Bearer ${TOKEN}" https://headscale.example.com/api/v1/node/8 | jq .node.online;

true
false
true

Environment

- OS: Ubuntu 22.04
- Headscale version: 0.26
- Tailscale version: N/A

Runtime environment

  • Headscale is behind a (reverse) proxy
  • Headscale runs in a container

Debug information

Just the above command output is sufficient.

Originally created by @GoodiesHQ on GitHub (May 30, 2025). ### Is this a support request? - [x] This is not a support request ### Is there an existing issue for this? - [x] I have searched the existing issues ### Current Behavior When sending a POST request to `/api/v1/node/<NodeID>/approved_routes`, the response is the node object ``` "v1SetApprovedRoutesResponse": { "type": "object", "properties": { "node": { "$ref": "#/definitions/v1Node" } } }, ``` However, it seems like no matter what the status is of the node before-hand, it will always be reported as `online: false` within the response's node object. The node is online, then approve_routes displays the status as offline, then immediately shows online again. ### Expected Behavior The status of the node should not change. ### Steps To Reproduce Forgive me for using the annoying escape mechanics of windows powershell, but I can run this compound command. It checks a node and uses jq to parse the ".node.online" value. It returns true. Then it updates the node's approved routes, and prints out the same ".node.online" value. Finally, it performs the first request again just to check the node's true online status. ``` PS C:\> >> curl.exe -s -H "Authorization: Bearer ${TOKEN}" https://headscale.example.com/api/v1/node/8 | jq .node.online; >> curl.exe -s -H "Authorization: Bearer ${TOKEN}" -X POST -d "{\`"routes\`":[\`"192.168.0.0/16\`"]}" https://headscale.example.com/api/v1/node/8/approve_routes | jq .node.online; >> curl.exe -s -H "Authorization: Bearer ${TOKEN}" https://headscale.example.com/api/v1/node/8 | jq .node.online; true false true ``` ### Environment ```markdown - OS: Ubuntu 22.04 - Headscale version: 0.26 - Tailscale version: N/A ``` ### Runtime environment - [x] Headscale is behind a (reverse) proxy - [x] Headscale runs in a container ### Debug information Just the above command output is sufficient.
adam added the bugno-stale-botroutes labels 2025-12-29 02:27:53 +01:00
adam closed this issue 2025-12-29 02:27:53 +01:00
adam commented 2025-12-29 02:27:53 +01:00
Author
Owner
Copy Link

@kradalby commented on GitHub (Sep 9, 2025):

Could you try the current HEAD of the main branch?

@kradalby commented on GitHub (Sep 9, 2025): Could you try the current HEAD of the main branch?
adam commented 2025-12-29 02:27:53 +01:00
Author
Owner
Copy Link

@kradalby commented on GitHub (Sep 12, 2025):

This should be fixed in HEAD, please test and reopen if not fixed in the next release.

@kradalby commented on GitHub (Sep 12, 2025): This should be fixed in HEAD, please test and reopen if not fixed in the next release.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label bug no-stale-bot routes
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#1039
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?