starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-13 04:40:29 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[Bug] PR #2474 can cause duplicate users #1017

New Issue
Closed
opened 2025-12-29 02:27:32 +01:00 by adam · 0 comments
adam commented 2025-12-29 02:27:32 +01:00
Owner
Copy Link

Originally created by @lordwelch on GitHub (May 10, 2025).

Is this a support request?

  • This is not a support request

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

Re-authenticating via OIDC created a duplicate user

Expected Behavior

Re-Authenticating via OIDC authenticates to the same existing user

Steps To Reproduce

  1. Authenticate to headscale using OIDC
  2. Note that the provider_identifier field in the database has a double slash
  3. Upgrade to 0.26.0-beta.1
  4. Re-authenticate via the same OIDC account
  5. A duplicate account is created, with the only difference being the original account has a duplicate slash // the new account has a single slash /

Environment

- OS: Fedora CoreOS 42
- Headscale version: 0.26.0-beta.1
- Tailscale version: 1.82.5

Runtime environment

  • Headscale is behind a (reverse) proxy
  • Headscale runs in a container

Debug information

PR #2474 changed the provider_identifier to be a properly joined url. This can cause duplicate users that are identical except for a duplicate /

Originally created by @lordwelch on GitHub (May 10, 2025). ### Is this a support request? - [x] This is not a support request ### Is there an existing issue for this? - [x] I have searched the existing issues ### Current Behavior Re-authenticating via OIDC created a duplicate user ### Expected Behavior Re-Authenticating via OIDC authenticates to the same existing user ### Steps To Reproduce 1. Authenticate to headscale using OIDC 2. Note that the `provider_identifier` field in the database has a double slash 3. Upgrade to 0.26.0-beta.1 4. Re-authenticate via the same OIDC account 5. A duplicate account is created, with the only difference being the original account has a duplicate slash `//` the new account has a single slash `/` ### Environment ```markdown - OS: Fedora CoreOS 42 - Headscale version: 0.26.0-beta.1 - Tailscale version: 1.82.5 ``` ### Runtime environment - [x] Headscale is behind a (reverse) proxy - [ ] Headscale runs in a container ### Debug information PR #2474 changed the provider_identifier to be a properly joined url. This can cause duplicate users that are identical except for a duplicate `/`
adam added the bug label 2025-12-29 02:27:32 +01:00
adam closed this issue 2025-12-29 02:27:32 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#1017
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?