starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

Ability to remove a node #10

New Issue
Closed
opened 2025-12-29 01:19:48 +01:00 by adam · 11 comments
adam commented 2025-12-29 01:19:48 +01:00
Owner
Copy Link

Originally created by @viq on GitHub (Jul 16, 2021).

Currently nodes can only be added. I'd like to be able to remove nodes that don't exist anymore (without going into SQL myself).

Originally created by @viq on GitHub (Jul 16, 2021). Currently nodes can only be added. I'd like to be able to remove nodes that don't exist anymore (without going into SQL myself).
adam closed this issue 2025-12-29 01:19:48 +01:00
adam commented 2025-12-29 01:19:49 +01:00
Author
Owner
Copy Link

@juanfont commented on GitHub (Jul 19, 2021):

Done! Although you might have to reload headscale for changes to take effect. We will be working on that next.

@juanfont commented on GitHub (Jul 19, 2021): Done! Although you might have to reload headscale for changes to take effect. We will be working on that next.
adam commented 2025-12-29 01:19:50 +01:00
Author
Owner
Copy Link

@viq commented on GitHub (Jul 22, 2021):

Seems also the same is true for ephemeral nodes - they get cleaned up only on headscale restart.

@viq commented on GitHub (Jul 22, 2021): Seems also the same is true for ephemeral nodes - they get cleaned up only on headscale restart.
adam commented 2025-12-29 01:19:51 +01:00
Author
Owner
Copy Link

@juanfont commented on GitHub (Jul 22, 2021):

That really sounds like something is being cached. Are you serving this
through Cloudflare by any chance?

On Thu, 22 Jul 2021 at 22:35, viq @.***> wrote:

Seems also the same is true for ephemeral nodes - they get cleaned up only
on headscale restart.

—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/juanfont/headscale/issues/52#issuecomment-885215406,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABMGQZMIKDPN7PXIDJKM73TZB6KLANCNFSM5AQFGKQA
.

@juanfont commented on GitHub (Jul 22, 2021): That really sounds like something is being cached. Are you serving this through Cloudflare by any chance? On Thu, 22 Jul 2021 at 22:35, viq ***@***.***> wrote: > Seems also the same is true for ephemeral nodes - they get cleaned up only > on headscale restart. > > — > You are receiving this because you modified the open/close state. > Reply to this email directly, view it on GitHub > <https://github.com/juanfont/headscale/issues/52#issuecomment-885215406>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AABMGQZMIKDPN7PXIDJKM73TZB6KLANCNFSM5AQFGKQA> > . >
adam commented 2025-12-29 01:19:51 +01:00
Author
Owner
Copy Link

@viq commented on GitHub (Jul 22, 2021):

No, purely my infra: couple OpenBSD boxes on libvirt on a dedicated server,
and all the pieces are running on them. The only possible caching is via
nginx, and I thought I disabled it in config.

On Thu, 22 Jul 2021, 23:11 Juan Font, @.***> wrote:

That really sounds like something is being cached. Are you serving this
through Cloudflare by any chance?

On Thu, 22 Jul 2021 at 22:35, viq @.***> wrote:

Seems also the same is true for ephemeral nodes - they get cleaned up
only
on headscale restart.

—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<https://github.com/juanfont/headscale/issues/52#issuecomment-885215406
,
or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/AABMGQZMIKDPN7PXIDJKM73TZB6KLANCNFSM5AQFGKQA

.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/juanfont/headscale/issues/52#issuecomment-885236938,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAE4DZNFUYQ4C7AYTMCMLN3TZCCQ7ANCNFSM5AQFGKQA
.

@viq commented on GitHub (Jul 22, 2021): No, purely my infra: couple OpenBSD boxes on libvirt on a dedicated server, and all the pieces are running on them. The only possible caching is via nginx, and I thought I disabled it in config. On Thu, 22 Jul 2021, 23:11 Juan Font, ***@***.***> wrote: > That really sounds like something is being cached. Are you serving this > through Cloudflare by any chance? > > On Thu, 22 Jul 2021 at 22:35, viq ***@***.***> wrote: > > > Seems also the same is true for ephemeral nodes - they get cleaned up > only > > on headscale restart. > > > > — > > You are receiving this because you modified the open/close state. > > Reply to this email directly, view it on GitHub > > <https://github.com/juanfont/headscale/issues/52#issuecomment-885215406 > >, > > or unsubscribe > > < > https://github.com/notifications/unsubscribe-auth/AABMGQZMIKDPN7PXIDJKM73TZB6KLANCNFSM5AQFGKQA > > > > . > > > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <https://github.com/juanfont/headscale/issues/52#issuecomment-885236938>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAE4DZNFUYQ4C7AYTMCMLN3TZCCQ7ANCNFSM5AQFGKQA> > . >
adam commented 2025-12-29 01:19:52 +01:00
Author
Owner
Copy Link

@juanfont commented on GitHub (Jul 22, 2021):

Can you make sure all the requests arriving to nginx are fwded to
Headscale? It sounds very weird...

On Thu, 22 Jul 2021 at 23:24, viq @.***> wrote:

No, purely my infra: couple OpenBSD boxes on libvirt on a dedicated server,
and all the pieces are running on them. The only possible caching is via
nginx, and I thought I disabled it in config.

On Thu, 22 Jul 2021, 23:11 Juan Font, @.***> wrote:

That really sounds like something is being cached. Are you serving this
through Cloudflare by any chance?

On Thu, 22 Jul 2021 at 22:35, viq @.***> wrote:

Seems also the same is true for ephemeral nodes - they get cleaned up
only
on headscale restart.

—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<
https://github.com/juanfont/headscale/issues/52#issuecomment-885215406
,
or unsubscribe
<

https://github.com/notifications/unsubscribe-auth/AABMGQZMIKDPN7PXIDJKM73TZB6KLANCNFSM5AQFGKQA

.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<https://github.com/juanfont/headscale/issues/52#issuecomment-885236938
,
or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/AAE4DZNFUYQ4C7AYTMCMLN3TZCCQ7ANCNFSM5AQFGKQA

.

—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/juanfont/headscale/issues/52#issuecomment-885245211,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABMGQ7NHZAGIOBM3OOGKRDTZCECVANCNFSM5AQFGKQA
.

@juanfont commented on GitHub (Jul 22, 2021): Can you make sure all the requests arriving to nginx are fwded to Headscale? It sounds very weird... On Thu, 22 Jul 2021 at 23:24, viq ***@***.***> wrote: > No, purely my infra: couple OpenBSD boxes on libvirt on a dedicated server, > and all the pieces are running on them. The only possible caching is via > nginx, and I thought I disabled it in config. > > On Thu, 22 Jul 2021, 23:11 Juan Font, ***@***.***> wrote: > > > That really sounds like something is being cached. Are you serving this > > through Cloudflare by any chance? > > > > On Thu, 22 Jul 2021 at 22:35, viq ***@***.***> wrote: > > > > > Seems also the same is true for ephemeral nodes - they get cleaned up > > only > > > on headscale restart. > > > > > > — > > > You are receiving this because you modified the open/close state. > > > Reply to this email directly, view it on GitHub > > > < > https://github.com/juanfont/headscale/issues/52#issuecomment-885215406 > > >, > > > or unsubscribe > > > < > > > https://github.com/notifications/unsubscribe-auth/AABMGQZMIKDPN7PXIDJKM73TZB6KLANCNFSM5AQFGKQA > > > > > > . > > > > > > > — > > You are receiving this because you authored the thread. > > Reply to this email directly, view it on GitHub > > <https://github.com/juanfont/headscale/issues/52#issuecomment-885236938 > >, > > or unsubscribe > > < > https://github.com/notifications/unsubscribe-auth/AAE4DZNFUYQ4C7AYTMCMLN3TZCCQ7ANCNFSM5AQFGKQA > > > > . > > > > — > You are receiving this because you modified the open/close state. > Reply to this email directly, view it on GitHub > <https://github.com/juanfont/headscale/issues/52#issuecomment-885245211>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AABMGQ7NHZAGIOBM3OOGKRDTZCECVANCNFSM5AQFGKQA> > . >
adam commented 2025-12-29 01:19:52 +01:00
Author
Owner
Copy Link

@viq commented on GitHub (Jul 25, 2021):

I just verified with tailscaled on a couple machines connecting directly to headscale's port 8000, and even when headscale logged removal of the ephemeral node, all other machines still show it listed in tailscale status. They'll get removed if I restart tailscaled and it talks to headscale for updates, but without restarts/re-connections those nodes do remain listed.

@viq commented on GitHub (Jul 25, 2021): I just verified with `tailscaled` on a couple machines connecting directly to `headscale`'s port `8000`, and even when `headscale` logged removal of the ephemeral node, all other machines still show it listed in `tailscale status`. They'll get removed if I restart `tailscaled` and it talks to `headscale` for updates, but without restarts/re-connections those nodes do remain listed.
adam commented 2025-12-29 01:19:52 +01:00
Author
Owner
Copy Link

@viq commented on GitHub (Jul 25, 2021):

Though I'll add this is with 0.3.4, I didn't try building master. Would
you expect different result there?

On Sun, 25 Jul 2021, 12:01 Juan Font, @.***> wrote:

Reopened #52 https://github.com/juanfont/headscale/issues/52.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/juanfont/headscale/issues/52#event-5064795729, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAE4DZNS6AJTTAAPDE7R3ATTZPOITANCNFSM5AQFGKQA
.

@viq commented on GitHub (Jul 25, 2021): Though I'll add this is with `0.3.4`, I didn't try building `master`. Would you expect different result there? On Sun, 25 Jul 2021, 12:01 Juan Font, ***@***.***> wrote: > Reopened #52 <https://github.com/juanfont/headscale/issues/52>. > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <https://github.com/juanfont/headscale/issues/52#event-5064795729>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAE4DZNS6AJTTAAPDE7R3ATTZPOITANCNFSM5AQFGKQA> > . >
adam commented 2025-12-29 01:19:53 +01:00
Author
Owner
Copy Link

@juanfont commented on GitHub (Jul 25, 2021):

I will tag a new release as soon as https://github.com/juanfont/headscale/pull/63 is merged. Apologies for the late response, busy week :(

@juanfont commented on GitHub (Jul 25, 2021): I will tag a new release as soon as https://github.com/juanfont/headscale/pull/63 is merged. Apologies for the late response, busy week :(
adam commented 2025-12-29 01:19:53 +01:00
Author
Owner
Copy Link

@viq commented on GitHub (Jul 25, 2021):

Thanks :)
No need to apologise, those are very quick responses for my standards ;)

On Sun, 25 Jul 2021, 18:06 Juan Font, @.***> wrote:

I will tag a new release as soon as #63
https://github.com/juanfont/headscale/pull/63 is merged. Apologies for
the late response, busy week :(

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/juanfont/headscale/issues/52#issuecomment-886223272,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAE4DZJOJV4RKBCR55R75H3TZQZBFANCNFSM5AQFGKQA
.

@viq commented on GitHub (Jul 25, 2021): Thanks :) No need to apologise, those are very quick responses for my standards ;) On Sun, 25 Jul 2021, 18:06 Juan Font, ***@***.***> wrote: > I will tag a new release as soon as #63 > <https://github.com/juanfont/headscale/pull/63> is merged. Apologies for > the late response, busy week :( > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <https://github.com/juanfont/headscale/issues/52#issuecomment-886223272>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAE4DZJOJV4RKBCR55R75H3TZQZBFANCNFSM5AQFGKQA> > . >
adam commented 2025-12-29 01:19:54 +01:00
Author
Owner
Copy Link

@juanfont commented on GitHub (Aug 8, 2021):

This is fixed now :)

@juanfont commented on GitHub (Aug 8, 2021): This is fixed now :)
adam commented 2025-12-29 01:19:55 +01:00
Author
Owner
Copy Link

@djkazic commented on GitHub (Jul 1, 2023):

I'm seeing this behavior on headscale 0.22.3.

I'd register a node A, then once I see it in headscale nodes list, remove it with headscale nodes delete -i 5. Confirmed it's gone from the list, but tailscale status on my other machines would still have it there, and it could continue to network.

Only when I restart the tailscale daemon does the connection drop. If I restart the tailscale app of the removed node, similarly, it updates then.

I looked at the code and there doesn't seem to be any polling now, but rather usage of a mapper. Does that mapper suffer from the same issue as what was seen here?

Context: I wanted to write some code that would be able to eject a node from the tailnet, but this doesn't seem possible.

Update: figured out what I did wrong. I should have been calling expire prior to deleting the machines.

@djkazic commented on GitHub (Jul 1, 2023): ~~I'm seeing this behavior on headscale `0.22.3`.~~ ~~I'd register a node A, then once I see it in `headscale nodes list`, remove it with `headscale nodes delete -i 5`. Confirmed it's gone from the list, but `tailscale status` on my other machines would still have it there, and it could continue to network.~~ ~~Only when I restart the tailscale daemon does the connection drop. If I restart the tailscale app of the removed node, similarly, it updates then.~~ ~~I looked at the code and there doesn't seem to be any polling now, but rather usage of a mapper. Does that mapper suffer from the same issue as what was seen here?~~ ~~Context: I wanted to write some code that would be able to eject a node from the tailnet, but this doesn't seem possible.~~ Update: figured out what I did wrong. I should have been calling `expire` prior to deleting the machines.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#10
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?