starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-04-24 09:38:45 +02:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

hscontrol/state: fix online status reset during re-registration

Browse Source 
Two fixes to how online status is handled during registration:

1. Re-registration (applyAuthNodeUpdate, HandleNodeFromPreAuthKey) no
   longer resets IsOnline to false. Online status is managed exclusively
   by Connect()/Disconnect() in the poll session lifecycle. The reset
   caused a false offline blip: the auth handler's change notification
   triggered a map regeneration showing the node as offline to peers,
   even though Connect() would set it back to true moments later.

2. New node creation (createAndSaveNewNode) now explicitly sets
   IsOnline=false instead of leaving it nil. This ensures peers always
   receive a known online status rather than an ambiguous nil/unknown.
This commit is contained in:
Kristoffer Dalby
2026-03-17 14:36:18 +00:00
parent b09af3846b
commit 1053fbb16b
1 changed files with 9 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
hscontrol/state/state.go
View File

@@ -1332,7 +1332,11 @@ func (s *State) applyAuthNodeUpdate(params authNodeUpdateParams) (types.NodeView
) )
node.Endpoints = regNv.Endpoints().AsSlice() node.Endpoints = regNv.Endpoints().AsSlice()
node.IsOnline = new(false) // Do NOT reset IsOnline here. Online status is managed exclusively by
// Connect()/Disconnect() in the poll session lifecycle. Resetting it
// during re-registration causes a false offline blip: the change
// notification triggers a map regeneration showing the node as offline
// to peers, even though Connect() will immediately set it back to true.
node.LastSeen = new(time.Now()) node.LastSeen = new(time.Now())
// Set RegisterMethod - for conversion this is the new method, // Set RegisterMethod - for conversion this is the new method,
@@ -1436,6 +1440,7 @@ func (s *State) createAndSaveNewNode(params newNodeParams) (types.NodeView, erro
Hostinfo: params.Hostinfo, Hostinfo: params.Hostinfo,
Endpoints: params.Endpoints, Endpoints: params.Endpoints,
LastSeen: new(time.Now()), LastSeen: new(time.Now()),
IsOnline: new(false), // Explicitly offline until Connect() is called
RegisterMethod: params.RegisterMethod, RegisterMethod: params.RegisterMethod,
Expiry: params.Expiry, Expiry: params.Expiry,
} }
@@ -1973,7 +1978,9 @@ func (s *State) HandleNodeFromPreAuthKey(
// Only update AuthKey reference. // Only update AuthKey reference.
node.AuthKey = pak node.AuthKey = pak
node.AuthKeyID = &pak.ID node.AuthKeyID = &pak.ID
node.IsOnline = new(false) // Do NOT reset IsOnline here. Online status is managed exclusively by
// Connect()/Disconnect() in the poll session lifecycle. Resetting it
// during re-registration causes a false offline blip to peers.
node.LastSeen = new(time.Now()) node.LastSeen = new(time.Now())
// Tagged nodes keep their existing expiry (disabled). // Tagged nodes keep their existing expiry (disabled).