mirror of
https://github.com/yusing/godoxy.git
synced 2026-03-23 09:52:01 +01:00
41de86de75
Replace the rewrite requirement check with a BodyResponseModifier marker and treat header and body modifiers separately. This ensures header/status rewrites still apply when body rewriting is blocked (for binary, encoded, or chunked responses), while body changes are skipped safely. It also avoids body reset/close side effects and returns early on passthrough responses. Update middleware tests to cover split header/body behavior and themed middleware body-skip scenarios.
89 lines
2.3 KiB
Go
89 lines
2.3 KiB
Go
package middleware
|
|
|
|
import (
|
|
"net/http"
|
|
"strconv"
|
|
|
|
gperr "github.com/yusing/goutils/errs"
|
|
)
|
|
|
|
type middlewareChain struct {
|
|
befores []RequestModifier
|
|
respHeader []ResponseModifier
|
|
respBody []ResponseModifier
|
|
}
|
|
|
|
// TODO: check conflict or duplicates.
|
|
func NewMiddlewareChain(name string, chain []*Middleware) *Middleware {
|
|
chainMid := &middlewareChain{}
|
|
m := &Middleware{name: name, impl: chainMid}
|
|
|
|
for _, comp := range chain {
|
|
if before, ok := comp.impl.(RequestModifier); ok {
|
|
chainMid.befores = append(chainMid.befores, before)
|
|
}
|
|
if mr, ok := comp.impl.(ResponseModifier); ok {
|
|
if isBodyResponseModifier(mr) {
|
|
chainMid.respBody = append(chainMid.respBody, mr)
|
|
} else {
|
|
chainMid.respHeader = append(chainMid.respHeader, mr)
|
|
}
|
|
}
|
|
}
|
|
return m
|
|
}
|
|
|
|
// before implements RequestModifier.
|
|
func (m *middlewareChain) before(w http.ResponseWriter, r *http.Request) (proceedNext bool) {
|
|
if len(m.befores) == 0 {
|
|
return true
|
|
}
|
|
for _, b := range m.befores {
|
|
if proceedNext = b.before(w, r); !proceedNext {
|
|
return false
|
|
}
|
|
}
|
|
return true
|
|
}
|
|
|
|
// modifyResponse implements ResponseModifier.
|
|
func (m *middlewareChain) modifyResponse(resp *http.Response) error {
|
|
for i, mr := range m.respHeader {
|
|
if err := mr.modifyResponse(resp); err != nil {
|
|
return gperr.PrependSubject(err, strconv.Itoa(i))
|
|
}
|
|
}
|
|
if len(m.respBody) == 0 || !canBufferAndModifyResponseBody(responseHeaderForBodyRewriteGate(resp)) {
|
|
return nil
|
|
}
|
|
headerLen := len(m.respHeader)
|
|
for i, mr := range m.respBody {
|
|
if err := mr.modifyResponse(resp); err != nil {
|
|
return gperr.PrependSubject(err, strconv.Itoa(i+headerLen))
|
|
}
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func isBodyResponseModifier(mr ResponseModifier) bool {
|
|
if chain, ok := mr.(*middlewareChain); ok {
|
|
return len(chain.respBody) > 0
|
|
}
|
|
if bypass, ok := mr.(*checkBypass); ok {
|
|
return isBodyResponseModifier(bypass.modRes)
|
|
}
|
|
_, ok := mr.(BodyResponseModifier)
|
|
return ok
|
|
}
|
|
|
|
func responseHeaderForBodyRewriteGate(resp *http.Response) http.Header {
|
|
h := resp.Header.Clone()
|
|
if len(resp.TransferEncoding) > 0 && len(h.Values("Transfer-Encoding")) == 0 {
|
|
h["Transfer-Encoding"] = append([]string(nil), resp.TransferEncoding...)
|
|
}
|
|
if resp.ContentLength >= 0 && h.Get("Content-Length") == "" {
|
|
h.Set("Content-Length", strconv.FormatInt(resp.ContentLength, 10))
|
|
}
|
|
return h
|
|
}
|