starred/godoxy
1
0
Fork 0
mirror of https://github.com/yusing/godoxy.git synced 2026-01-11 21:10:30 +01:00
Code Issues 18 Packages Projects Releases 10 Wiki Activity

OIDC Allowed Users doesn't seem optional anymore #76

New Issue
Closed
opened 2025-12-29 09:22:40 +01:00 by adam · 1 comment
adam commented 2025-12-29 09:22:40 +01:00
Owner
Copy Link

Originally created by @codestronger on GitHub (May 24, 2025).

The OIDC docs mention that allowed users is optional, but that doesn't seem to be the case anymore. I took a look at the code in oidc.go checkAllowed() and it seems to confirm that the behavior was changed when adding offline access support (b815c6f). Anyway, wanted to let you know about the discrepancy. Really cool project btw!

Originally created by @codestronger on GitHub (May 24, 2025). The [OIDC docs](https://docs.godoxy.dev/Home#oidc) mention that allowed users is optional, but that doesn't seem to be the case anymore. I took a look at the code in [oidc.go checkAllowed()](https://github.com/yusing/godoxy/blob/main/internal/auth/oidc.go#L202-L211) and it seems to confirm that the behavior was changed when adding offline access support (b815c6f). Anyway, wanted to let you know about the discrepancy. Really cool project btw!
adam closed this issue 2025-12-29 09:22:40 +01:00
adam commented 2025-12-29 09:22:41 +01:00
Author
Owner
Copy Link

@yusing commented on GitHub (May 25, 2025):

Thanks for reminding, I have made the change to revert to old behavior (logical OR) instead of current (logical AND).

@yusing commented on GitHub (May 25, 2025): Thanks for reminding, I have made the change to revert to old behavior (logical OR) instead of current (logical AND).
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
enhancement
pull-request
Mirrored from GitHub Pull Request
 wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/godoxy#76
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?