[PR #98] [CLOSED] feat(oidc): refresh_token support via offline_access scope #168

New Issue

adam · 2025-12-29T09:23:45+01:00

adam commented

2025-12-29 09:23:45 +01:00

📋 Pull Request Information

Original PR: https://github.com/yusing/godoxy/pull/98
Author: @yusing
Created: 4/23/2025
Status: ❌ Closed

Base: dev ← Head: hotfix/oidc

📝 Commits (10+)

aad4403 chore: add rule files and debug dir to .gitignore
8f03662 chore: upgrade go to 1.24.2 and dependencies
36fab0c fix(oidc): simplify and fix oidc middleware url handling
6277622 refactor(oidc): simplify initiialization flow, replace go-oidc with own forked version
23482da fix(route): panic on middleware error
d60688c fix(route): error not being returned
5a984f5 chore: remove unused debugging printing
0a8aa2b fix(oidc): use XFH header from backend for cookie domain
ef48340 security: drop service headers
077641b refactor(oidc): simplify exchange method

📊 Changes

29 files changed (+867 additions, -497 deletions)

View changed files

📝 .env.example (+10 -7)
📝 .gitignore (+3 -0)
📝 Dockerfile (+1 -1)
📝 cmd/main.go (+1 -1)
📝 go.mod (+25 -23)
📝 go.sum (+52 -48)
📝 internal/api/handler.go (+12 -15)
➖ internal/api/v1/auth/oidc.go (+0 -308)
➖ internal/api/v1/auth/provider.go (+0 -13)
📝 internal/auth/auth.go (+8 -0)
📝 internal/auth/block_page.go (+0 -0)
📝 internal/auth/block_page.html (+0 -0)
➕ internal/auth/oauth_refresh.go (+185 -0)
➕ internal/auth/oidc.go (+314 -0)
📝 internal/auth/oidc_test.go (+46 -16)
➕ internal/auth/provider.go (+9 -0)
📝 internal/auth/userpass.go (+6 -9)
📝 internal/auth/userpass_test.go (+1 -1)
📝 internal/auth/utils.go (+23 -21)
📝 internal/common/constants.go (+2 -0)

...and 9 more files

📄 Description

No description provided

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/yusing/godoxy/pull/98 **Author:** [@yusing](https://github.com/yusing) **Created:** 4/23/2025 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `hotfix/oidc` --- ### 📝 Commits (10+) - [`aad4403`](https://github.com/yusing/godoxy/commit/aad44031c40660978d1407999b9153949ab5ff4f) chore: add rule files and debug dir to .gitignore - [`8f03662`](https://github.com/yusing/godoxy/commit/8f0366298210f4d58c30652eaac69bea20447be6) chore: upgrade go to 1.24.2 and dependencies - [`36fab0c`](https://github.com/yusing/godoxy/commit/36fab0cd5053b73c39bd9b245f73ca5f6346109c) fix(oidc): simplify and fix oidc middleware url handling - [`6277622`](https://github.com/yusing/godoxy/commit/62776229cb8a95a82911d0d6b4f6ce9a3f7f1516) refactor(oidc): simplify initiialization flow, replace go-oidc with own forked version - [`23482da`](https://github.com/yusing/godoxy/commit/23482da259e34631545426c02392ec705a412d04) fix(route): panic on middleware error - [`d60688c`](https://github.com/yusing/godoxy/commit/d60688c66fee935740495a0281ff1db99f1328b6) fix(route): error not being returned - [`5a984f5`](https://github.com/yusing/godoxy/commit/5a984f5c0c265ecff62d6d8dac1bcdb49273237c) chore: remove unused debugging printing - [`0a8aa2b`](https://github.com/yusing/godoxy/commit/0a8aa2b215a2ca9fb41f7a7046b4900314653f67) fix(oidc): use XFH header from backend for cookie domain - [`ef48340`](https://github.com/yusing/godoxy/commit/ef483403da38c37384f543b0899049c7ef02b4d4) security: drop service headers - [`077641b`](https://github.com/yusing/godoxy/commit/077641beaa58871c14e51ad0b2853643d6f8f414) refactor(oidc): simplify exchange method ### 📊 Changes **29 files changed** (+867 additions, -497 deletions) <details> <summary>View changed files</summary> 📝 `.env.example` (+10 -7) 📝 `.gitignore` (+3 -0) 📝 `Dockerfile` (+1 -1) 📝 `cmd/main.go` (+1 -1) 📝 `go.mod` (+25 -23) 📝 `go.sum` (+52 -48) 📝 `internal/api/handler.go` (+12 -15) ➖ `internal/api/v1/auth/oidc.go` (+0 -308) ➖ `internal/api/v1/auth/provider.go` (+0 -13) 📝 `internal/auth/auth.go` (+8 -0) 📝 `internal/auth/block_page.go` (+0 -0) 📝 `internal/auth/block_page.html` (+0 -0) ➕ `internal/auth/oauth_refresh.go` (+185 -0) ➕ `internal/auth/oidc.go` (+314 -0) 📝 `internal/auth/oidc_test.go` (+46 -16) ➕ `internal/auth/provider.go` (+9 -0) 📝 `internal/auth/userpass.go` (+6 -9) 📝 `internal/auth/userpass_test.go` (+1 -1) 📝 `internal/auth/utils.go` (+23 -21) 📝 `internal/common/constants.go` (+2 -0) _...and 9 more files_ </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-29 09:23:45 +01:00

adam closed this issue

2025-12-29 09:23:45 +01:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/godoxy#168