[PR #91] [MERGED] refactor: rename utils/testing to expect, replace all dot imports in tests #163

New Issue

adam · 2025-12-29T09:23:44+01:00

adam commented

2025-12-29 09:23:44 +01:00

📋 Pull Request Information

Original PR: https://github.com/yusing/godoxy/pull/91
Author: @yusing
Created: 4/17/2025
Status: ✅ Merged
Merged: 4/17/2025
Merged by: @yusing

Base: main ← Head: refactor/organize-code

📝 Commits (10+)

cfd1d8f fix: improved sync.Pool handling
c7e0dcb refactor: ping if-flow and remove timeout
0866feb refactor: enhance favicon fetching with context support and improve cache management
c80a557 fix: log formatting
9af42a9 feat(pool): add checkExists method to debug build to detect unexpected behavior
7f4b04e chore: cont. 0866feb
1fe21b8 refactor: unify route handling by consolidating route query methods with Pool
41bef09 chore: uncomment icon list cache code
78bed43 refactor: update task management code
0a13bcb refactor: enhance idlewatcher logging and exit handling

📊 Changes

59 files changed (+780 additions, -773 deletions)

View changed files

📝 agent/pkg/agent/new_agent_test.go (+20 -20)
📝 agent/pkg/certs/zip_test.go (+6 -6)
📝 agent/pkg/handler/check_health_test.go (+17 -16)
📝 internal/api/v1/auth/oidc_test.go (+12 -12)
📝 internal/api/v1/auth/userpass_test.go (+18 -18)
📝 internal/autocert/provider_test/ovh_test.go (+5 -4)
📝 internal/config/config_test.go (+14 -15)
📝 internal/docker/container_test.go (+3 -2)
📝 internal/entrypoint/entrypoint_test.go (+5 -4)
📝 internal/gperr/builder_test.go (+9 -10)
📝 internal/gperr/error_test.go (+38 -38)
📝 internal/gperr/multiline_test.go (+2 -2)
📝 internal/gperr/subject.go (+1 -1)
📝 internal/homepage/homepage_test.go (+2 -2)
📝 internal/homepage/icon_url_test.go (+4 -4)
📝 internal/idlewatcher/types/config_test.go (+2 -2)
📝 internal/metrics/systeminfo/system_info_test.go (+23 -22)
📝 internal/net/gphttp/accesslog/access_logger_test.go (+20 -20)
📝 internal/net/gphttp/accesslog/config_test.go (+20 -20)
📝 internal/net/gphttp/accesslog/fields_test.go (+17 -17)

...and 39 more files

📄 Description

No description provided

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/yusing/godoxy/pull/91 **Author:** [@yusing](https://github.com/yusing) **Created:** 4/17/2025 **Status:** ✅ Merged **Merged:** 4/17/2025 **Merged by:** [@yusing](https://github.com/yusing) **Base:** `main` ← **Head:** `refactor/organize-code` --- ### 📝 Commits (10+) - [`cfd1d8f`](https://github.com/yusing/godoxy/commit/cfd1d8fff0f0443028bbebca06cf0fcff39034f4) fix: improved sync.Pool handling - [`c7e0dcb`](https://github.com/yusing/godoxy/commit/c7e0dcbfd8e3dc3c96c0a2c58d4bce1af8608136) refactor: ping if-flow and remove timeout - [`0866feb`](https://github.com/yusing/godoxy/commit/0866feb81b57604449d2ca1b7b63f52b55af6119) refactor: enhance favicon fetching with context support and improve cache management - [`c80a557`](https://github.com/yusing/godoxy/commit/c80a557a427afab4518f567ccf45d274743afbf5) fix: log formatting - [`9af42a9`](https://github.com/yusing/godoxy/commit/9af42a9439141ee18056fefa6cf108653209860f) feat(pool): add checkExists method to debug build to detect unexpected behavior - [`7f4b04e`](https://github.com/yusing/godoxy/commit/7f4b04efb76ea6e8e404078853ae49184be96a53) chore: cont. 0866feb - [`1fe21b8`](https://github.com/yusing/godoxy/commit/1fe21b84eb317aa6b328c6a7cb80d3aafbbabf8c) refactor: unify route handling by consolidating route query methods with Pool - [`41bef09`](https://github.com/yusing/godoxy/commit/41bef09be298225f335b8606ab7a47a350198ab8) chore: uncomment icon list cache code - [`78bed43`](https://github.com/yusing/godoxy/commit/78bed431994fc0f93290fe3d9efcd4dcb3b85bb3) refactor: update task management code - [`0a13bcb`](https://github.com/yusing/godoxy/commit/0a13bcb8a3711083f8c279caa4e5c4ce3dfb549b) refactor: enhance idlewatcher logging and exit handling ### 📊 Changes **59 files changed** (+780 additions, -773 deletions) <details> <summary>View changed files</summary> 📝 `agent/pkg/agent/new_agent_test.go` (+20 -20) 📝 `agent/pkg/certs/zip_test.go` (+6 -6) 📝 `agent/pkg/handler/check_health_test.go` (+17 -16) 📝 `internal/api/v1/auth/oidc_test.go` (+12 -12) 📝 `internal/api/v1/auth/userpass_test.go` (+18 -18) 📝 `internal/autocert/provider_test/ovh_test.go` (+5 -4) 📝 `internal/config/config_test.go` (+14 -15) 📝 `internal/docker/container_test.go` (+3 -2) 📝 `internal/entrypoint/entrypoint_test.go` (+5 -4) 📝 `internal/gperr/builder_test.go` (+9 -10) 📝 `internal/gperr/error_test.go` (+38 -38) 📝 `internal/gperr/multiline_test.go` (+2 -2) 📝 `internal/gperr/subject.go` (+1 -1) 📝 `internal/homepage/homepage_test.go` (+2 -2) 📝 `internal/homepage/icon_url_test.go` (+4 -4) 📝 `internal/idlewatcher/types/config_test.go` (+2 -2) 📝 `internal/metrics/systeminfo/system_info_test.go` (+23 -22) 📝 `internal/net/gphttp/accesslog/access_logger_test.go` (+20 -20) 📝 `internal/net/gphttp/accesslog/config_test.go` (+20 -20) 📝 `internal/net/gphttp/accesslog/fields_test.go` (+17 -17) _...and 39 more files_ </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-29 09:23:44 +01:00

adam closed this issue

2025-12-29 09:23:44 +01:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/godoxy#163