simplify task package implementation

internal/net/http/accesslog/config.go

@@ -22,6 +22,7 @@ type (
 		Path       string  `json:"path" validate:"required"`
 		Filters    Filters `json:"filters"`
 		Fields     Fields  `json:"fields"`
+		// Retention  *Retention
 	}
 )
 
@@ -31,7 +32,7 @@ var (
 	FormatJSON     Format = "json"
 )
 
-const DefaultBufferSize = 100
+const DefaultBufferSize = 64 * 1024 // 64KB
 
 func DefaultConfig() *Config {
 	return &Config{

internal/net/http/accesslog/file_logger.go

@@ -0,0 +1,22 @@
+package accesslog
+
+import (
+	"fmt"
+	"os"
+	"sync"
+
+	"github.com/yusing/go-proxy/internal/task"
+)
+
+type File struct {
+	*os.File
+	sync.Mutex
+}
+
+func NewFileAccessLogger(parent task.Parent, cfg *Config) (*AccessLogger, error) {
+	f, err := os.OpenFile(cfg.Path, os.O_APPEND|os.O_CREATE|os.O_WRONLY, 0o644)
+	if err != nil {
+		return nil, fmt.Errorf("access log open error: %w", err)
+	}
+	return NewAccessLogger(parent, &File{File: f}, cfg), nil
+}

internal/net/http/accesslog/formatter.go

@@ -7,18 +7,17 @@ import (
 	"net/http"
 	"net/url"
 	"strconv"
+	"time"
 )
 
 type (
 	CommonFormatter struct {
-		cfg *Fields
-	}
-	CombinedFormatter struct {
-		CommonFormatter
-	}
-	JSONFormatter struct {
-		CommonFormatter
+		cfg        *Fields
+		GetTimeNow func() time.Time // for testing purposes only
 	}
+	CombinedFormatter CommonFormatter
+	JSONFormatter     CommonFormatter
+
 	JSONLogEntry struct {
 		Time        string              `json:"time"`
 		IP          string              `json:"ip"`
@@ -39,6 +38,8 @@ type (
 	}
 )
 
+const LogTimeFormat = "02/Jan/2006:15:04:05 -0700"
+
 func scheme(req *http.Request) string {
 	if req.TLS != nil {
 		return "https"
@@ -62,7 +63,7 @@ func clientIP(req *http.Request) string {
 	return req.RemoteAddr
 }
 
-func (f CommonFormatter) Format(line *bytes.Buffer, req *http.Request, res *http.Response) {
+func (f *CommonFormatter) Format(line *bytes.Buffer, req *http.Request, res *http.Response) {
 	query := f.cfg.Query.ProcessQuery(req.URL.Query())
 
 	line.WriteString(req.Host)
@@ -71,7 +72,7 @@ func (f CommonFormatter) Format(line *bytes.Buffer, req *http.Request, res *http
 	line.WriteString(clientIP(req))
 	line.WriteString(" - - [")
 
-	line.WriteString(timeNow())
+	line.WriteString(f.GetTimeNow().Format(LogTimeFormat))
 	line.WriteString("] \"")
 
 	line.WriteString(req.Method)
@@ -86,8 +87,8 @@ func (f CommonFormatter) Format(line *bytes.Buffer, req *http.Request, res *http
 	line.WriteString(strconv.FormatInt(res.ContentLength, 10))
 }
 
-func (f CombinedFormatter) Format(line *bytes.Buffer, req *http.Request, res *http.Response) {
-	f.CommonFormatter.Format(line, req, res)
+func (f *CombinedFormatter) Format(line *bytes.Buffer, req *http.Request, res *http.Response) {
+	(*CommonFormatter)(f).Format(line, req, res)
 	line.WriteString(" \"")
 	line.WriteString(req.Referer())
 	line.WriteString("\" \"")
@@ -95,14 +96,14 @@ func (f CombinedFormatter) Format(line *bytes.Buffer, req *http.Request, res *ht
 	line.WriteRune('"')
 }
 
-func (f JSONFormatter) Format(line *bytes.Buffer, req *http.Request, res *http.Response) {
+func (f *JSONFormatter) Format(line *bytes.Buffer, req *http.Request, res *http.Response) {
 	query := f.cfg.Query.ProcessQuery(req.URL.Query())
 	headers := f.cfg.Headers.ProcessHeaders(req.Header)
 	headers.Del("Cookie")
 	cookies := f.cfg.Cookies.ProcessCookies(req.Cookies())
 
 	entry := JSONLogEntry{
-		Time:        timeNow(),
+		Time:        f.GetTimeNow().Format(LogTimeFormat),
 		IP:          clientIP(req),
 		Method:      req.Method,
 		Scheme:      scheme(req),