starred/godoxy
1
0
Fork 0
mirror of https://github.com/yusing/godoxy.git synced 2026-04-25 02:09:01 +02:00
Code Issues 18 Packages Projects Releases 10 Wiki Activity

refactor(metrics): remove pointers from type parameter T to avoid unnecessary indirection

Browse Source
This commit is contained in:
yusing
2025-08-28 22:30:40 +08:00
parent 205928a741
commit 0a5df1bd7f
4 changed files with 20 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
internal/metrics/period/handler.go
View File

@@ -3,6 +3,7 @@ package period
import (
"errors"
"net/http"
"net/url"
"time"
"github.com/gin-gonic/gin"
@@ -29,6 +30,7 @@ type ResponseType[AggregateT any] struct {
//
// If the request is a websocket request, it serves the data for the given period for every interval.
func (p *Poller[T, AggregateT]) ServeHTTP(c *gin.Context) {
period := Filter(c.Query("period"))
query := c.Request.URL.Query()
if httpheaders.IsWebsocket(c.Request.Header) {
@@ -42,10 +44,10 @@ func (p *Poller[T, AggregateT]) ServeHTTP(c *gin.Context) {
interval = minInterval
}
websocket.PeriodicWrite(c, interval, func() (any, error) {
return p.getRespData(c.Request)
return p.getRespData(period, query)
})
} else {
data, err := p.getRespData(c.Request)
data, err := p.getRespData(period, query)
if err != nil {
c.Error(apitypes.InternalServerError(err, "failed to get response data"))
return
@@ -58,13 +60,11 @@ func (p *Poller[T, AggregateT]) ServeHTTP(c *gin.Context) {
}
}
func (p *Poller[T, AggregateT]) getRespData(r *http.Request) (any, error) {
query := r.URL.Query()
period := query.Get("period")
func (p *Poller[T, AggregateT]) getRespData(period Filter, query url.Values) (any, error) {
if period == "" {
return p.GetLastResult(), nil
}
rangeData, ok := p.Get(Filter(period))
rangeData, ok := p.Get(period)
if !ok {
return nil, errors.New("invalid period")
}