[PR #41] [MERGED] feat: add groups support for OIDC claims #148

Closed
opened 2025-12-29 14:25:41 +01:00 by adam · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/yusing/godoxy/pull/41
Author: @polds
Created: 1/14/2025
Status: Merged
Merged: 1/14/2025
Merged by: @yusing

Base: feat/oidc-middlewareHead: feat/oidc-group-support


📝 Commits (1)

  • 73de18e feat: add groups support for OIDC claims

📊 Changes

7 files changed (+442 additions, -43 deletions)

View changed files

📝 .env.example (+14 -1)
📝 internal/api/v1/auth/oidc.go (+25 -13)
📝 internal/api/v1/auth/oidc_test.go (+275 -22)
📝 internal/common/env.go (+7 -6)
📝 internal/net/http/middleware/oidc.go (+5 -1)
internal/utils/slices.go (+20 -0)
internal/utils/slices_test.go (+96 -0)

📄 Description

Allow users to specify allowed groups in the env and use it to inspect the claims.

This performs a logical AND of users and groups (additive).


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/yusing/godoxy/pull/41 **Author:** [@polds](https://github.com/polds) **Created:** 1/14/2025 **Status:** ✅ Merged **Merged:** 1/14/2025 **Merged by:** [@yusing](https://github.com/yusing) **Base:** `feat/oidc-middleware` ← **Head:** `feat/oidc-group-support` --- ### 📝 Commits (1) - [`73de18e`](https://github.com/yusing/godoxy/commit/73de18e19745885d2a6af38c2cd6c0b21fa8f6b7) feat: add groups support for OIDC claims ### 📊 Changes **7 files changed** (+442 additions, -43 deletions) <details> <summary>View changed files</summary> 📝 `.env.example` (+14 -1) 📝 `internal/api/v1/auth/oidc.go` (+25 -13) 📝 `internal/api/v1/auth/oidc_test.go` (+275 -22) 📝 `internal/common/env.go` (+7 -6) 📝 `internal/net/http/middleware/oidc.go` (+5 -1) ➕ `internal/utils/slices.go` (+20 -0) ➕ `internal/utils/slices_test.go` (+96 -0) </details> ### 📄 Description Allow users to specify allowed groups in the env and use it to inspect the claims. This performs a logical AND of users and groups (additive). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 14:25:41 +01:00
adam closed this issue 2025-12-29 14:25:41 +01:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/godoxy-yusing#148