starred/godoxy-yusing
1
0
Fork 0
mirror of https://github.com/yusing/godoxy.git synced 2026-03-25 18:41:10 +01:00
Code Issues 18 Packages Projects Releases 10 Wiki Activity

fix: docker test and golangci-lint

Browse Source
This commit is contained in:
yusing
2025-01-13 05:37:29 +08:00
parent 9a12dab600
commit ef277ef57f
4 changed files with 13 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
internal/api/v1/auth/auth.go
View File

@@ -51,7 +51,7 @@ func LoginHandler(w http.ResponseWriter, r *http.Request) {
U.HandleErr(w, r, err, http.StatusUnauthorized)
return
}
if err := setAuthenticatedCookie(w, r, creds.Username); err != nil {
if err := setAuthenticatedCookie(w, creds.Username); err != nil {
U.HandleErr(w, r, err, http.StatusInternalServerError)
return
}
@@ -72,7 +72,7 @@ func AuthMethodHandler(w http.ResponseWriter, r *http.Request) {
w.WriteHeader(http.StatusOK)
}
func setAuthenticatedCookie(w http.ResponseWriter, r *http.Request, username string) error {
func setAuthenticatedCookie(w http.ResponseWriter, username string) error {
expiresAt := time.Now().Add(common.APIJWTTokenTTL)
claim := &Claims{
Username: username,

10
internal/api/v1/auth/oidc.go
View File

@@ -20,7 +20,7 @@ var (
oidcVerifier *oidc.IDTokenVerifier
)
// InitOIDC initializes the OIDC provider
// InitOIDC initializes the OIDC provider.
func InitOIDC(issuerURL, clientID, clientSecret, redirectURL string) error {
if issuerURL == "" {
return nil // OIDC not configured
@@ -47,7 +47,7 @@ func InitOIDC(issuerURL, clientID, clientSecret, redirectURL string) error {
return nil
}
// OIDCLoginHandler initiates the OIDC login flow
// OIDCLoginHandler initiates the OIDC login flow.
func OIDCLoginHandler(w http.ResponseWriter, r *http.Request) {
if oauthConfig == nil {
U.HandleErr(w, r, E.New("OIDC not configured"), http.StatusNotImplemented)
@@ -69,7 +69,7 @@ func OIDCLoginHandler(w http.ResponseWriter, r *http.Request) {
http.Redirect(w, r, url, http.StatusTemporaryRedirect)
}
// OIDCCallbackHandler handles the OIDC callback
// OIDCCallbackHandler handles the OIDC callback.
func OIDCCallbackHandler(w http.ResponseWriter, r *http.Request) {
if oauthConfig == nil {
U.HandleErr(w, r, E.New("OIDC not configured"), http.StatusNotImplemented)
@@ -126,7 +126,7 @@ func OIDCCallbackHandler(w http.ResponseWriter, r *http.Request) {
return
}
if err := setAuthenticatedCookie(w, r, claims.Username); err != nil {
if err := setAuthenticatedCookie(w, claims.Username); err != nil {
U.HandleErr(w, r, err, http.StatusInternalServerError)
return
}
@@ -135,7 +135,7 @@ func OIDCCallbackHandler(w http.ResponseWriter, r *http.Request) {
http.Redirect(w, r, "/", http.StatusTemporaryRedirect)
}
// handleTestCallback handles OIDC callback in test environment
// handleTestCallback handles OIDC callback in test environment.
func handleTestCallback(w http.ResponseWriter, r *http.Request) {
state, err := r.Cookie("oauth_state")
if err != nil {

6
internal/api/v1/auth/oidc_test.go
View File

@@ -10,7 +10,7 @@ import (
"golang.org/x/oauth2"
)
// setupMockOIDC configures mock OIDC provider for testing
// setupMockOIDC configures mock OIDC provider for testing.
func setupMockOIDC(t *testing.T) {
t.Helper()
@@ -68,7 +68,7 @@ func TestOIDCLoginHandler(t *testing.T) {
oauthConfig = nil
}
req := httptest.NewRequest("GET", "/login/oidc", nil)
req := httptest.NewRequest(http.MethodGet, "/login/oidc", nil)
w := httptest.NewRecorder()
OIDCLoginHandler(w, req)
@@ -143,7 +143,7 @@ func TestOIDCCallbackHandler(t *testing.T) {
oauthConfig = nil
}
req := httptest.NewRequest("GET", "/auth/callback?code="+tt.code+"&state="+tt.state, nil)
req := httptest.NewRequest(http.MethodGet, "/auth/callback?code="+tt.code+"&state="+tt.state, nil)
if tt.state != "" {
req.AddCookie(&http.Cookie{
Name: "oauth_state",