starred/godoxy-yusing
1
0
Fork 0
mirror of https://github.com/yusing/godoxy.git synced 2026-04-23 16:58:31 +02:00
Code Issues 18 Packages Projects Releases 10 Wiki Activity

refactor(http): enhance health check error logic by treating all 5xx as unhealthy

Browse Source
This commit is contained in:
yusing
2025-12-17 12:24:04 +08:00
parent 21a23dd147
commit bd92c46375
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
internal/watcher/health/monitor/http.go
View File

@@ -60,8 +60,7 @@ func (mon *HTTPHealthMonitor) CheckHealth() (types.HealthCheckResult, error) {
respErr := pinger.DoTimeout(req, resp, mon.config.Timeout) respErr := pinger.DoTimeout(req, resp, mon.config.Timeout)
lat := time.Since(start) lat := time.Since(start)
switch { if respErr != nil {
case respErr != nil:
// treat TLS error as healthy // treat TLS error as healthy
var tlsErr *tls.CertificateVerificationError var tlsErr *tls.CertificateVerificationError
if ok := errors.As(respErr, &tlsErr); !ok { if ok := errors.As(respErr, &tlsErr); !ok {
@@ -70,7 +69,9 @@ func (mon *HTTPHealthMonitor) CheckHealth() (types.HealthCheckResult, error) {
Detail: respErr.Error(), Detail: respErr.Error(),
}, nil }, nil
} }
case resp.StatusCode() == fasthttp.StatusServiceUnavailable: }
if status := resp.StatusCode(); status >= 500 && status < 600 {
return types.HealthCheckResult{ return types.HealthCheckResult{
Latency: lat, Latency: lat,
Detail: fasthttp.StatusMessage(resp.StatusCode()), Detail: fasthttp.StatusMessage(resp.StatusCode()),