From 9f245a62f2e9a78bd6116dd5a8216522813229ec Mon Sep 17 00:00:00 2001
From: yusing <yusing.wys@gmail.com>
Date: Sun, 25 Jan 2026 18:05:36 +0800
Subject: [PATCH] fix(proxmox): concurrent map write in UpdateResources

---
 internal/proxmox/client.go | 23 +++++++++++++++--------
 1 file changed, 15 insertions(+), 8 deletions(-)

diff --git a/internal/proxmox/client.go b/internal/proxmox/client.go
index 421defd3..55c1e384 100644
--- a/internal/proxmox/client.go
+++ b/internal/proxmox/client.go
@@ -65,20 +65,21 @@ func (c *Client) UpdateClusterInfo(ctx context.Context) (err error) {
 }
 
 func (c *Client) UpdateResources(ctx context.Context) error {
-	c.resourcesMu.Lock()
-	defer c.resourcesMu.Unlock()
 	resourcesSlice, err := c.Cluster.Resources(ctx, "vm")
 	if err != nil {
 		return err
 	}
-	clear(c.resources)
-	var errs errgroup.Group
-	errs.SetLimit(runtime.GOMAXPROCS(0) * 2)
-	for _, resource := range resourcesSlice {
-		c.resources[resource.ID] = &VMResource{
+	vmResources := make([]*VMResource, len(resourcesSlice))
+	for i, resource := range resourcesSlice {
+		vmResources[i] = &VMResource{
 			ClusterResource: resource,
 			IPs:             nil,
 		}
+	}
+	var errs errgroup.Group
+	errs.SetLimit(runtime.GOMAXPROCS(0) * 2)
+	for i, resource := range resourcesSlice {
+		vmResource := vmResources[i]
 		errs.Go(func() error {
 			node, ok := Nodes.Get(resource.Node)
 			if !ok {
@@ -96,13 +97,19 @@ func (c *Client) UpdateResources(ctx context.Context) error {
 			if err != nil {
 				return fmt.Errorf("failed to get ips for resource %s: %w", resource.ID, err)
 			}
-			c.resources[resource.ID].IPs = ips
+			vmResource.IPs = ips
 			return nil
 		})
 	}
 	if err := errs.Wait(); err != nil {
 		return err
 	}
+	c.resourcesMu.Lock()
+	clear(c.resources)
+	for i, resource := range resourcesSlice {
+		c.resources[resource.ID] = vmResources[i]
+	}
+	c.resourcesMu.Unlock()
 	log.Debug().Str("cluster", c.Cluster.Name).Msgf("[proxmox] updated %d resources", len(c.resources))
 	return nil
 }