From 8df7eb2fe51d0be98fdce2b7ae5682e38b1747a8 Mon Sep 17 00:00:00 2001 From: yusing Date: Wed, 21 Jan 2026 23:52:37 +0800 Subject: [PATCH] fix(logging): correct variable shadowing in NewLoggerWithFixedLevel causing incorrect log level being assigned --- internal/logging/logging.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/internal/logging/logging.go b/internal/logging/logging.go index b02214ae..4674d894 100644 --- a/internal/logging/logging.go +++ b/internal/logging/logging.go @@ -92,7 +92,7 @@ func NewLogger(out ...io.Writer) zerolog.Logger { return zerolog.New(writer).Level(level).With().Timestamp().Logger() } -func NewLoggerWithFixedLevel(level zerolog.Level, out ...io.Writer) zerolog.Logger { +func NewLoggerWithFixedLevel(lvl zerolog.Level, out ...io.Writer) zerolog.Logger { writer := zerolog.NewConsoleWriter(func(w *zerolog.ConsoleWriter) { w.Out = multiLevelWriter(out...) w.TimeFormat = timeFmt @@ -103,5 +103,5 @@ func NewLoggerWithFixedLevel(level zerolog.Level, out ...io.Writer) zerolog.Logg return fmtMessage(msgI.(string)) } }) - return zerolog.New(writer).Level(level).With().Str("level", level.String()).Timestamp().Logger() + return zerolog.New(writer).Level(level).With().Str("level", lvl.String()).Timestamp().Logger() }