starred/godoxy-yusing
1
0
Fork 0
mirror of https://github.com/yusing/godoxy.git synced 2026-04-23 00:38:33 +02:00
Code Issues 18 Packages Projects Releases 10 Wiki Activity

fix(oidc): allow requests to proceed when OIDC is not enabled

Browse Source 
fix(oidc): ignore OIDC middleware when OIDC is not enabled

The OIDC middleware now gracefully handles the case when OIDC is not enabled by:
- Returning early in the before() hook when IsOIDCEnabled() is false
- Logging an error instead of returning an error in finalize() when OIDC is not configured
This commit is contained in:
yusing
2026-02-14 19:54:00 +08:00
parent 679045eb29
commit 8b2da08ec1
1 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
internal/net/gphttp/middleware/oidc.go
View File

@@ -7,6 +7,7 @@ import (
"sync" "sync"
"sync/atomic" "sync/atomic"
"github.com/rs/zerolog/log"
"github.com/yusing/godoxy/internal/auth" "github.com/yusing/godoxy/internal/auth"
"github.com/yusing/goutils/http/httpheaders" "github.com/yusing/goutils/http/httpheaders"
) )
@@ -28,7 +29,7 @@ var OIDC = NewMiddleware[oidcMiddleware]()
func (amw *oidcMiddleware) finalize() error { func (amw *oidcMiddleware) finalize() error {
if !auth.IsOIDCEnabled() { if !auth.IsOIDCEnabled() {
return errors.New("OIDC not enabled but OIDC middleware is used") log.Error().Msg("OIDC not enabled but OIDC middleware is used")
} }
return nil return nil
} }
@@ -97,6 +98,10 @@ func (amw *oidcMiddleware) initSlow() error {
} }
func (amw *oidcMiddleware) before(w http.ResponseWriter, r *http.Request) (proceed bool) { func (amw *oidcMiddleware) before(w http.ResponseWriter, r *http.Request) (proceed bool) {
if !auth.IsOIDCEnabled() {
return true
}
if err := amw.init(); err != nil { if err := amw.init(); err != nil {
// no need to log here, main OIDC should've already failed and logged // no need to log here, main OIDC should've already failed and logged
http.Error(w, err.Error(), http.StatusInternalServerError) http.Error(w, err.Error(), http.StatusInternalServerError)