From 848f26aa86a5012185710a7e5c516bafc3bf9555 Mon Sep 17 00:00:00 2001
From: yusing <yusing.wys@gmail.com>
Date: Sat, 11 Oct 2025 19:05:49 +0800
Subject: [PATCH] test(list-icon): fix tests regarding previous changes

---
 internal/homepage/list_icons_test.go | 30 +++++++++++-----------------
 1 file changed, 12 insertions(+), 18 deletions(-)

diff --git a/internal/homepage/list_icons_test.go b/internal/homepage/list_icons_test.go
index 104eaed1..d22e8704 100644
--- a/internal/homepage/list_icons_test.go
+++ b/internal/homepage/list_icons_test.go
@@ -67,11 +67,11 @@ type testCases struct {
 	IconMeta
 }
 
-func runTests(t *testing.T, iconsCache *Cache, test []testCases) {
+func runTests(t *testing.T, iconsCache IconMap, test []testCases) {
 	t.Helper()
 
 	for _, item := range test {
-		icon, ok := iconsCache.Icons[item.Key]
+		icon, ok := iconsCache[item.Key]
 		if !ok {
 			t.Fatalf("icon %s not found", item.Key)
 		}
@@ -94,15 +94,12 @@ func TestListWalkxCodeIcons(t *testing.T) {
 	t.Cleanup(TestClearIconsCache)
 
 	MockHTTPGet([]byte(walkxcodeIcons))
-	if err := UpdateWalkxCodeIcons(); err != nil {
+	m := make(IconMap)
+	if err := UpdateWalkxCodeIcons(m); err != nil {
 		t.Fatal(err)
 	}
-	iconsCache, err := ListAvailableIcons()
-	if err != nil {
-		t.Fatal(err)
-	}
-	if len(iconsCache.Icons) != 2 {
-		t.Fatalf("expect 2 icons, got %d", len(iconsCache.Icons))
+	if len(m) != 2 {
+		t.Fatalf("expect 2 icons, got %d", len(m))
 	}
 	test := []testCases{
 		{
@@ -122,21 +119,18 @@ func TestListWalkxCodeIcons(t *testing.T) {
 			},
 		},
 	}
-	runTests(t, iconsCache, test)
+	runTests(t, m, test)
 }
 
 func TestListSelfhstIcons(t *testing.T) {
 	t.Cleanup(TestClearIconsCache)
 	MockHTTPGet([]byte(selfhstIcons))
-	if err := UpdateSelfhstIcons(); err != nil {
+	m := make(IconMap)
+	if err := UpdateSelfhstIcons(m); err != nil {
 		t.Fatal(err)
 	}
-	iconsCache, err := ListAvailableIcons()
-	if err != nil {
-		t.Fatal(err)
-	}
-	if len(iconsCache.Icons) != 3 {
-		t.Fatalf("expect 3 icons, got %d", len(iconsCache.Icons))
+	if len(m) != 3 {
+		t.Fatalf("expect 3 icons, got %d", len(m))
 	}
 	test := []testCases{
 		{
@@ -171,5 +165,5 @@ func TestListSelfhstIcons(t *testing.T) {
 			},
 		},
 	}
-	runTests(t, iconsCache, test)
+	runTests(t, m, test)
 }