refactor(concurrency): simplify some waitgroup usage, remove extra wg.Done in wg.Go left in 11af9d1 in io.go

cmd/main.go

@@ -23,9 +23,7 @@ import (
 func parallel(fns ...func()) {
 	var wg sync.WaitGroup
 	for _, fn := range fns {
-		wg.Go(func() {
+		wg.Go(fn)
-			fn()
-		})
 	}
 	wg.Wait()
 }

internal/logging/accesslog/file_logger_test.go

@@ -82,12 +82,10 @@ func TestConcurrentAccessLoggerLogAndFlush(t *testing.T) {
 
 func parallelLog(logger *AccessLogger, req *http.Request, resp *http.Response, n int) {
 	var wg sync.WaitGroup
-	wg.Add(n)
 	for range n {
-		go func() {
+		wg.Go(func() {
-			defer wg.Done()
 			logger.Log(req, resp)
-		}()
+		})
 	}
 	wg.Wait()
 }

internal/task/task_test.go

@@ -128,7 +128,6 @@ func TestFinishMultipleCalls(t *testing.T) {
 	task := testTask()
 	var wg sync.WaitGroup
 	n := 20
-	wg.Add(n)
 	for range n {
 		wg.Go(func() {
 			task.Finish(nil)

internal/utils/io.go

@@ -95,11 +95,9 @@ func (p BidirectionalPipe) Start() error {
 	var srcErr, dstErr error
 	wg.Go(func() {
 		srcErr = p.pSrcDst.Start()
-		wg.Done()
 	})
 	wg.Go(func() {
 		dstErr = p.pDstSrc.Start()
-		wg.Done()
 	})
 	wg.Wait()
 	return errors.Join(srcErr, dstErr)

internal/utils/ref_count_test.go

@@ -15,9 +15,7 @@ func TestRefCounterAddSub(t *testing.T) {
 
 	rc.Add()
 	for range 2 {
-		wg.Go(func() {
+		wg.Go(rc.Sub)
-			rc.Sub()
-		})
 	}
 
 	wg.Wait()