mirror of
https://github.com/beshu-tech/deltaglider.git
synced 2026-04-23 08:48:32 +02:00
feat: Add bucket management APIs and improve SDK filtering
This commit adds core bucket management functionality and enhances the SDK's internal file filtering to provide a cleaner abstraction layer. **Bucket Management**: - Add create_bucket(), delete_bucket(), list_buckets() to DeltaGliderClient - Idempotent operations (creating existing bucket or deleting non-existent returns success) - Complete boto3-compatible API for basic bucket operations - Eliminates need for boto3 in most use cases **Enhanced SDK Filtering**: - SDK now filters .delta suffix and reference.bin from all list_objects() responses - Simplified CLI to rely on SDK filtering (removed duplicate logic) - Single source of truth for internal file hiding **Delete Cleanup Logic**: - Automatically removes orphaned reference.bin when last delta in DeltaSpace is deleted - Prevents storage waste from abandoned reference files - Works for both single delete() and recursive delete_recursive() **Documentation & Testing**: - Added BOTO3_COMPATIBILITY.md documenting actual 20% method coverage (21/100+ methods) - Updated README to reflect accurate boto3 compatibility claims - New comprehensive test suite for filtering and cleanup features (test_filtering_and_cleanup.py) - New bucket management test suite (test_bucket_management.py) - Example code for bucket lifecycle management (examples/bucket_management.py) - Fixed mypy configuration to eliminate source file found twice errors - All CI checks passing (lint, format, type check, 18 unit tests, 61 integration tests) **Cleanup**: - Removed PYPI_RELEASE.md (redundant with existing docs) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
Simone Scarduzio
237
tests/integration/test_bucket_management.py
Normal file
237
tests/integration/test_bucket_management.py
Normal file
@@ -0,0 +1,237 @@
|
||||
"""Tests for bucket management APIs."""
|
||||
|
||||
from unittest.mock import Mock
|
||||
|
||||
import pytest
|
||||
|
||||
from deltaglider.app.cli.main import create_service
|
||||
from deltaglider.client import DeltaGliderClient
|
||||
|
||||
|
||||
class TestBucketManagement:
|
||||
"""Test bucket creation, listing, and deletion."""
|
||||
|
||||
def test_create_bucket_success(self):
|
||||
"""Test creating a bucket successfully."""
|
||||
service = create_service()
|
||||
mock_storage = Mock()
|
||||
service.storage = mock_storage
|
||||
|
||||
# Mock boto3 client
|
||||
mock_boto3_client = Mock()
|
||||
mock_boto3_client.create_bucket.return_value = {"Location": "/test-bucket"}
|
||||
mock_storage.client = mock_boto3_client
|
||||
|
||||
client = DeltaGliderClient(service)
|
||||
response = client.create_bucket(Bucket="test-bucket")
|
||||
|
||||
# Verify response
|
||||
assert response["Location"] == "/test-bucket"
|
||||
assert response["ResponseMetadata"]["HTTPStatusCode"] == 200
|
||||
|
||||
# Verify boto3 was called correctly
|
||||
mock_boto3_client.create_bucket.assert_called_once_with(Bucket="test-bucket")
|
||||
|
||||
def test_create_bucket_with_region(self):
|
||||
"""Test creating a bucket in a specific region."""
|
||||
service = create_service()
|
||||
mock_storage = Mock()
|
||||
service.storage = mock_storage
|
||||
|
||||
# Mock boto3 client
|
||||
mock_boto3_client = Mock()
|
||||
mock_boto3_client.create_bucket.return_value = {
|
||||
"Location": "http://test-bucket.s3.us-west-2.amazonaws.com/"
|
||||
}
|
||||
mock_storage.client = mock_boto3_client
|
||||
|
||||
client = DeltaGliderClient(service)
|
||||
response = client.create_bucket(
|
||||
Bucket="test-bucket",
|
||||
CreateBucketConfiguration={"LocationConstraint": "us-west-2"},
|
||||
)
|
||||
|
||||
# Verify response
|
||||
assert "Location" in response
|
||||
assert response["ResponseMetadata"]["HTTPStatusCode"] == 200
|
||||
|
||||
# Verify boto3 was called with region config
|
||||
mock_boto3_client.create_bucket.assert_called_once_with(
|
||||
Bucket="test-bucket", CreateBucketConfiguration={"LocationConstraint": "us-west-2"}
|
||||
)
|
||||
|
||||
def test_create_bucket_already_exists(self):
|
||||
"""Test creating a bucket that already exists returns success."""
|
||||
service = create_service()
|
||||
mock_storage = Mock()
|
||||
service.storage = mock_storage
|
||||
|
||||
# Mock boto3 client to raise BucketAlreadyExists
|
||||
mock_boto3_client = Mock()
|
||||
mock_boto3_client.create_bucket.side_effect = Exception("BucketAlreadyOwnedByYou")
|
||||
mock_storage.client = mock_boto3_client
|
||||
|
||||
client = DeltaGliderClient(service)
|
||||
response = client.create_bucket(Bucket="existing-bucket")
|
||||
|
||||
# Should return success (idempotent)
|
||||
assert response["Location"] == "/existing-bucket"
|
||||
assert response["ResponseMetadata"]["HTTPStatusCode"] == 200
|
||||
|
||||
def test_list_buckets_success(self):
|
||||
"""Test listing buckets."""
|
||||
service = create_service()
|
||||
mock_storage = Mock()
|
||||
service.storage = mock_storage
|
||||
|
||||
# Mock boto3 client
|
||||
mock_boto3_client = Mock()
|
||||
mock_boto3_client.list_buckets.return_value = {
|
||||
"Buckets": [
|
||||
{"Name": "bucket1", "CreationDate": "2025-01-01T00:00:00Z"},
|
||||
{"Name": "bucket2", "CreationDate": "2025-01-02T00:00:00Z"},
|
||||
],
|
||||
"Owner": {"DisplayName": "test-user", "ID": "12345"},
|
||||
}
|
||||
mock_storage.client = mock_boto3_client
|
||||
|
||||
client = DeltaGliderClient(service)
|
||||
response = client.list_buckets()
|
||||
|
||||
# Verify response
|
||||
assert len(response["Buckets"]) == 2
|
||||
assert response["Buckets"][0]["Name"] == "bucket1"
|
||||
assert response["Buckets"][1]["Name"] == "bucket2"
|
||||
assert response["Owner"]["DisplayName"] == "test-user"
|
||||
assert response["ResponseMetadata"]["HTTPStatusCode"] == 200
|
||||
|
||||
def test_list_buckets_empty(self):
|
||||
"""Test listing buckets when none exist."""
|
||||
service = create_service()
|
||||
mock_storage = Mock()
|
||||
service.storage = mock_storage
|
||||
|
||||
# Mock boto3 client with empty result
|
||||
mock_boto3_client = Mock()
|
||||
mock_boto3_client.list_buckets.return_value = {"Buckets": [], "Owner": {}}
|
||||
mock_storage.client = mock_boto3_client
|
||||
|
||||
client = DeltaGliderClient(service)
|
||||
response = client.list_buckets()
|
||||
|
||||
# Verify empty list
|
||||
assert response["Buckets"] == []
|
||||
assert response["ResponseMetadata"]["HTTPStatusCode"] == 200
|
||||
|
||||
def test_delete_bucket_success(self):
|
||||
"""Test deleting a bucket successfully."""
|
||||
service = create_service()
|
||||
mock_storage = Mock()
|
||||
service.storage = mock_storage
|
||||
|
||||
# Mock boto3 client
|
||||
mock_boto3_client = Mock()
|
||||
mock_boto3_client.delete_bucket.return_value = None
|
||||
mock_storage.client = mock_boto3_client
|
||||
|
||||
client = DeltaGliderClient(service)
|
||||
response = client.delete_bucket(Bucket="test-bucket")
|
||||
|
||||
# Verify response
|
||||
assert response["ResponseMetadata"]["HTTPStatusCode"] == 204
|
||||
|
||||
# Verify boto3 was called
|
||||
mock_boto3_client.delete_bucket.assert_called_once_with(Bucket="test-bucket")
|
||||
|
||||
def test_delete_bucket_not_found(self):
|
||||
"""Test deleting a bucket that doesn't exist returns success."""
|
||||
service = create_service()
|
||||
mock_storage = Mock()
|
||||
service.storage = mock_storage
|
||||
|
||||
# Mock boto3 client to raise NoSuchBucket
|
||||
mock_boto3_client = Mock()
|
||||
mock_boto3_client.delete_bucket.side_effect = Exception("NoSuchBucket")
|
||||
mock_storage.client = mock_boto3_client
|
||||
|
||||
client = DeltaGliderClient(service)
|
||||
response = client.delete_bucket(Bucket="nonexistent-bucket")
|
||||
|
||||
# Should return success (idempotent)
|
||||
assert response["ResponseMetadata"]["HTTPStatusCode"] == 204
|
||||
|
||||
def test_delete_bucket_not_empty_raises_error(self):
|
||||
"""Test deleting a non-empty bucket raises an error."""
|
||||
service = create_service()
|
||||
mock_storage = Mock()
|
||||
service.storage = mock_storage
|
||||
|
||||
# Mock boto3 client to raise BucketNotEmpty
|
||||
mock_boto3_client = Mock()
|
||||
mock_boto3_client.delete_bucket.side_effect = Exception(
|
||||
"BucketNotEmpty: The bucket you tried to delete is not empty"
|
||||
)
|
||||
mock_storage.client = mock_boto3_client
|
||||
|
||||
client = DeltaGliderClient(service)
|
||||
|
||||
with pytest.raises(RuntimeError, match="Failed to delete bucket"):
|
||||
client.delete_bucket(Bucket="full-bucket")
|
||||
|
||||
def test_bucket_methods_without_boto3_client(self):
|
||||
"""Test that bucket methods raise NotImplementedError when storage doesn't support it."""
|
||||
service = create_service()
|
||||
mock_storage = Mock()
|
||||
service.storage = mock_storage
|
||||
|
||||
# Storage adapter without boto3 client (no 'client' attribute)
|
||||
delattr(mock_storage, "client")
|
||||
|
||||
client = DeltaGliderClient(service)
|
||||
|
||||
# All bucket methods should raise NotImplementedError
|
||||
with pytest.raises(NotImplementedError):
|
||||
client.create_bucket(Bucket="test")
|
||||
|
||||
with pytest.raises(NotImplementedError):
|
||||
client.delete_bucket(Bucket="test")
|
||||
|
||||
with pytest.raises(NotImplementedError):
|
||||
client.list_buckets()
|
||||
|
||||
def test_complete_bucket_lifecycle(self):
|
||||
"""Test complete bucket lifecycle: create, use, delete."""
|
||||
service = create_service()
|
||||
mock_storage = Mock()
|
||||
service.storage = mock_storage
|
||||
|
||||
# Mock boto3 client
|
||||
mock_boto3_client = Mock()
|
||||
mock_storage.client = mock_boto3_client
|
||||
|
||||
# Setup responses
|
||||
mock_boto3_client.create_bucket.return_value = {"Location": "/test-lifecycle"}
|
||||
mock_boto3_client.list_buckets.return_value = {
|
||||
"Buckets": [{"Name": "test-lifecycle", "CreationDate": "2025-01-01T00:00:00Z"}],
|
||||
"Owner": {},
|
||||
}
|
||||
mock_boto3_client.delete_bucket.return_value = None
|
||||
|
||||
client = DeltaGliderClient(service)
|
||||
|
||||
# 1. Create bucket
|
||||
create_response = client.create_bucket(Bucket="test-lifecycle")
|
||||
assert create_response["ResponseMetadata"]["HTTPStatusCode"] == 200
|
||||
|
||||
# 2. List buckets - verify it exists
|
||||
list_response = client.list_buckets()
|
||||
bucket_names = [b["Name"] for b in list_response["Buckets"]]
|
||||
assert "test-lifecycle" in bucket_names
|
||||
|
||||
# 3. Delete bucket
|
||||
delete_response = client.delete_bucket(Bucket="test-lifecycle")
|
||||
assert delete_response["ResponseMetadata"]["HTTPStatusCode"] == 204
|
||||
|
||||
|
||||
if __name__ == "__main__":
|
||||
pytest.main([__file__, "-v"])
|
||||
434
tests/integration/test_filtering_and_cleanup.py
Normal file
434
tests/integration/test_filtering_and_cleanup.py
Normal file
@@ -0,0 +1,434 @@
|
||||
"""Tests for SDK filtering and delete cleanup functionality."""
|
||||
|
||||
from datetime import UTC, datetime
|
||||
from unittest.mock import Mock
|
||||
|
||||
import pytest
|
||||
|
||||
from deltaglider.app.cli.main import create_service
|
||||
from deltaglider.client import DeltaGliderClient
|
||||
from deltaglider.core import ObjectKey
|
||||
from deltaglider.ports.storage import ObjectHead
|
||||
|
||||
|
||||
class TestSDKFiltering:
|
||||
"""Test that SDK filters .delta and reference.bin from list_objects()."""
|
||||
|
||||
def test_list_objects_filters_delta_suffix(self):
|
||||
"""Test that .delta suffix is stripped from object keys."""
|
||||
service = create_service()
|
||||
mock_storage = Mock()
|
||||
service.storage = mock_storage
|
||||
|
||||
# Mock list_objects response with .delta files
|
||||
mock_storage.list_objects.return_value = {
|
||||
"objects": [
|
||||
{
|
||||
"key": "releases/app-v1.zip.delta",
|
||||
"size": 1000,
|
||||
"last_modified": "2025-01-01T00:00:00Z",
|
||||
"etag": "abc123",
|
||||
"storage_class": "STANDARD",
|
||||
},
|
||||
{
|
||||
"key": "releases/app-v2.zip.delta",
|
||||
"size": 1500,
|
||||
"last_modified": "2025-01-02T00:00:00Z",
|
||||
"etag": "def456",
|
||||
"storage_class": "STANDARD",
|
||||
},
|
||||
{
|
||||
"key": "releases/README.md",
|
||||
"size": 500,
|
||||
"last_modified": "2025-01-03T00:00:00Z",
|
||||
"etag": "ghi789",
|
||||
"storage_class": "STANDARD",
|
||||
},
|
||||
],
|
||||
"common_prefixes": [],
|
||||
"is_truncated": False,
|
||||
"next_continuation_token": None,
|
||||
}
|
||||
|
||||
client = DeltaGliderClient(service)
|
||||
response = client.list_objects(Bucket="test-bucket", Prefix="releases/")
|
||||
|
||||
# Verify .delta suffix is stripped
|
||||
keys = [obj.key for obj in response.contents]
|
||||
assert "releases/app-v1.zip" in keys
|
||||
assert "releases/app-v2.zip" in keys
|
||||
assert "releases/README.md" in keys
|
||||
|
||||
# Verify NO .delta suffixes in output
|
||||
for key in keys:
|
||||
assert not key.endswith(".delta"), f"Found .delta suffix in: {key}"
|
||||
|
||||
# Verify is_delta flag is set correctly
|
||||
delta_objects = [obj for obj in response.contents if obj.is_delta]
|
||||
assert len(delta_objects) == 2
|
||||
|
||||
def test_list_objects_filters_reference_bin(self):
|
||||
"""Test that reference.bin files are completely filtered out."""
|
||||
service = create_service()
|
||||
mock_storage = Mock()
|
||||
service.storage = mock_storage
|
||||
|
||||
# Mock list_objects response with reference.bin files
|
||||
mock_storage.list_objects.return_value = {
|
||||
"objects": [
|
||||
{
|
||||
"key": "releases/reference.bin",
|
||||
"size": 50000,
|
||||
"last_modified": "2025-01-01T00:00:00Z",
|
||||
"etag": "ref123",
|
||||
"storage_class": "STANDARD",
|
||||
},
|
||||
{
|
||||
"key": "releases/1.0/reference.bin",
|
||||
"size": 50000,
|
||||
"last_modified": "2025-01-01T00:00:00Z",
|
||||
"etag": "ref456",
|
||||
"storage_class": "STANDARD",
|
||||
},
|
||||
{
|
||||
"key": "releases/app.zip.delta",
|
||||
"size": 1000,
|
||||
"last_modified": "2025-01-02T00:00:00Z",
|
||||
"etag": "app123",
|
||||
"storage_class": "STANDARD",
|
||||
},
|
||||
],
|
||||
"common_prefixes": [],
|
||||
"is_truncated": False,
|
||||
"next_continuation_token": None,
|
||||
}
|
||||
|
||||
client = DeltaGliderClient(service)
|
||||
response = client.list_objects(Bucket="test-bucket", Prefix="releases/")
|
||||
|
||||
# Verify NO reference.bin files in output
|
||||
keys = [obj.key for obj in response.contents]
|
||||
for key in keys:
|
||||
assert not key.endswith("reference.bin"), f"Found reference.bin in: {key}"
|
||||
|
||||
# Should only have the app.zip (with .delta stripped)
|
||||
assert len(response.contents) == 1
|
||||
assert response.contents[0].key == "releases/app.zip"
|
||||
assert response.contents[0].is_delta is True
|
||||
|
||||
def test_list_objects_combined_filtering(self):
|
||||
"""Test filtering of both .delta and reference.bin together."""
|
||||
service = create_service()
|
||||
mock_storage = Mock()
|
||||
service.storage = mock_storage
|
||||
|
||||
# Mock comprehensive file list
|
||||
mock_storage.list_objects.return_value = {
|
||||
"objects": [
|
||||
{
|
||||
"key": "data/reference.bin",
|
||||
"size": 50000,
|
||||
"last_modified": "2025-01-01T00:00:00Z",
|
||||
"etag": "1",
|
||||
},
|
||||
{
|
||||
"key": "data/file1.zip.delta",
|
||||
"size": 1000,
|
||||
"last_modified": "2025-01-01T00:00:00Z",
|
||||
"etag": "2",
|
||||
},
|
||||
{
|
||||
"key": "data/file2.zip.delta",
|
||||
"size": 1500,
|
||||
"last_modified": "2025-01-01T00:00:00Z",
|
||||
"etag": "3",
|
||||
},
|
||||
{
|
||||
"key": "data/file3.txt",
|
||||
"size": 500,
|
||||
"last_modified": "2025-01-01T00:00:00Z",
|
||||
"etag": "4",
|
||||
},
|
||||
{
|
||||
"key": "data/sub/reference.bin",
|
||||
"size": 50000,
|
||||
"last_modified": "2025-01-01T00:00:00Z",
|
||||
"etag": "5",
|
||||
},
|
||||
{
|
||||
"key": "data/sub/app.jar.delta",
|
||||
"size": 2000,
|
||||
"last_modified": "2025-01-01T00:00:00Z",
|
||||
"etag": "6",
|
||||
},
|
||||
],
|
||||
"common_prefixes": [],
|
||||
"is_truncated": False,
|
||||
"next_continuation_token": None,
|
||||
}
|
||||
|
||||
client = DeltaGliderClient(service)
|
||||
response = client.list_objects(Bucket="test-bucket", Prefix="data/")
|
||||
|
||||
# Should filter out 2 reference.bin files
|
||||
# Should strip .delta from 3 files
|
||||
# Should keep 1 regular file as-is
|
||||
assert len(response.contents) == 4 # 3 deltas + 1 regular file
|
||||
|
||||
keys = [obj.key for obj in response.contents]
|
||||
expected_keys = ["data/file1.zip", "data/file2.zip", "data/file3.txt", "data/sub/app.jar"]
|
||||
assert sorted(keys) == sorted(expected_keys)
|
||||
|
||||
# Verify no internal files visible
|
||||
for key in keys:
|
||||
assert not key.endswith(".delta")
|
||||
assert not key.endswith("reference.bin")
|
||||
|
||||
|
||||
class TestSingleDeleteCleanup:
|
||||
"""Test that single delete() cleans up orphaned reference.bin."""
|
||||
|
||||
def test_delete_last_delta_cleans_reference(self):
|
||||
"""Test that deleting the last delta file removes orphaned reference.bin."""
|
||||
service = create_service()
|
||||
mock_storage = Mock()
|
||||
service.storage = mock_storage
|
||||
|
||||
# Mock head for both delta and reference.bin
|
||||
def mock_head_func(key):
|
||||
if key.endswith("app.zip.delta"):
|
||||
return ObjectHead(
|
||||
key="releases/app.zip.delta",
|
||||
size=1000,
|
||||
etag="abc123",
|
||||
last_modified=datetime.now(UTC),
|
||||
metadata={"original_name": "app.zip", "ref_key": "releases/reference.bin"},
|
||||
)
|
||||
elif key.endswith("reference.bin"):
|
||||
return ObjectHead(
|
||||
key="releases/reference.bin",
|
||||
size=50000,
|
||||
etag="ref123",
|
||||
last_modified=datetime.now(UTC),
|
||||
metadata={},
|
||||
)
|
||||
return None
|
||||
|
||||
mock_storage.head.side_effect = mock_head_func
|
||||
|
||||
# Mock list to show NO other deltas remain
|
||||
mock_storage.list.return_value = [
|
||||
ObjectHead(
|
||||
key="releases/reference.bin",
|
||||
size=50000,
|
||||
etag="ref123",
|
||||
last_modified=datetime.now(UTC),
|
||||
metadata={},
|
||||
),
|
||||
]
|
||||
mock_storage.delete.return_value = None
|
||||
|
||||
# Delete the last delta
|
||||
result = service.delete(ObjectKey(bucket="test-bucket", key="releases/app.zip.delta"))
|
||||
|
||||
# Verify delta was deleted
|
||||
assert result["deleted"] is True
|
||||
assert result["type"] == "delta"
|
||||
|
||||
# Verify reference.bin cleanup was triggered
|
||||
assert "cleaned_reference" in result
|
||||
assert result["cleaned_reference"] == "releases/reference.bin"
|
||||
|
||||
# Verify both files were deleted
|
||||
assert mock_storage.delete.call_count == 2
|
||||
delete_calls = [call[0][0] for call in mock_storage.delete.call_args_list]
|
||||
assert "test-bucket/releases/app.zip.delta" in delete_calls
|
||||
assert "test-bucket/releases/reference.bin" in delete_calls
|
||||
|
||||
def test_delete_delta_keeps_reference_when_others_exist(self):
|
||||
"""Test that reference.bin is kept when other deltas remain."""
|
||||
service = create_service()
|
||||
mock_storage = Mock()
|
||||
service.storage = mock_storage
|
||||
|
||||
# Mock the delta file being deleted
|
||||
mock_storage.head.return_value = ObjectHead(
|
||||
key="releases/app-v1.zip.delta",
|
||||
size=1000,
|
||||
etag="abc123",
|
||||
last_modified=datetime.now(UTC),
|
||||
metadata={"original_name": "app-v1.zip"},
|
||||
)
|
||||
|
||||
# Mock list to show OTHER deltas still exist
|
||||
mock_storage.list.return_value = [
|
||||
ObjectHead(
|
||||
key="releases/app-v2.zip.delta",
|
||||
size=1500,
|
||||
etag="def456",
|
||||
last_modified=datetime.now(UTC),
|
||||
metadata={},
|
||||
),
|
||||
ObjectHead(
|
||||
key="releases/reference.bin",
|
||||
size=50000,
|
||||
etag="ref123",
|
||||
last_modified=datetime.now(UTC),
|
||||
metadata={},
|
||||
),
|
||||
]
|
||||
|
||||
mock_storage.delete.return_value = None
|
||||
|
||||
# Delete one delta (but others remain)
|
||||
result = service.delete(ObjectKey(bucket="test-bucket", key="releases/app-v1.zip.delta"))
|
||||
|
||||
# Verify delta was deleted
|
||||
assert result["deleted"] is True
|
||||
assert result["type"] == "delta"
|
||||
|
||||
# Verify reference.bin was NOT cleaned up
|
||||
assert "cleaned_reference" not in result
|
||||
|
||||
# Verify only the delta was deleted, not reference.bin
|
||||
assert mock_storage.delete.call_count == 1
|
||||
mock_storage.delete.assert_called_once_with("test-bucket/releases/app-v1.zip.delta")
|
||||
|
||||
def test_delete_delta_no_reference_exists(self):
|
||||
"""Test deleting delta when reference.bin doesn't exist (edge case)."""
|
||||
service = create_service()
|
||||
mock_storage = Mock()
|
||||
service.storage = mock_storage
|
||||
|
||||
# Mock the delta file
|
||||
mock_storage.head.return_value = ObjectHead(
|
||||
key="releases/app.zip.delta",
|
||||
size=1000,
|
||||
etag="abc123",
|
||||
last_modified=datetime.now(UTC),
|
||||
metadata={"original_name": "app.zip"},
|
||||
)
|
||||
|
||||
# Mock list shows no other deltas
|
||||
mock_storage.list.return_value = []
|
||||
|
||||
# Mock head for reference.bin returns None (doesn't exist)
|
||||
def mock_head_func(key):
|
||||
if key.endswith("reference.bin"):
|
||||
return None
|
||||
return ObjectHead(
|
||||
key="releases/app.zip.delta",
|
||||
size=1000,
|
||||
etag="abc123",
|
||||
last_modified=datetime.now(UTC),
|
||||
metadata={},
|
||||
)
|
||||
|
||||
mock_storage.head.side_effect = mock_head_func
|
||||
mock_storage.delete.return_value = None
|
||||
|
||||
# Delete the delta
|
||||
result = service.delete(ObjectKey(bucket="test-bucket", key="releases/app.zip.delta"))
|
||||
|
||||
# Verify delta was deleted
|
||||
assert result["deleted"] is True
|
||||
assert result["type"] == "delta"
|
||||
|
||||
# Verify no reference cleanup (since it didn't exist)
|
||||
assert "cleaned_reference" not in result
|
||||
|
||||
# Only delta should be deleted
|
||||
assert mock_storage.delete.call_count == 1
|
||||
|
||||
def test_delete_isolated_deltaspaces(self):
|
||||
"""Test that cleanup only affects the specific DeltaSpace."""
|
||||
service = create_service()
|
||||
mock_storage = Mock()
|
||||
service.storage = mock_storage
|
||||
|
||||
# Mock head for both delta and reference.bin
|
||||
def mock_head_func(key):
|
||||
if "1.0/app.zip.delta" in key:
|
||||
return ObjectHead(
|
||||
key="releases/1.0/app.zip.delta",
|
||||
size=1000,
|
||||
etag="abc123",
|
||||
last_modified=datetime.now(UTC),
|
||||
metadata={"original_name": "app.zip"},
|
||||
)
|
||||
elif "1.0/reference.bin" in key:
|
||||
return ObjectHead(
|
||||
key="releases/1.0/reference.bin",
|
||||
size=50000,
|
||||
etag="ref1",
|
||||
last_modified=datetime.now(UTC),
|
||||
metadata={},
|
||||
)
|
||||
return None
|
||||
|
||||
mock_storage.head.side_effect = mock_head_func
|
||||
|
||||
# Mock list for 1.0 - no other deltas
|
||||
mock_storage.list.return_value = [
|
||||
ObjectHead(
|
||||
key="releases/1.0/reference.bin",
|
||||
size=50000,
|
||||
etag="ref1",
|
||||
last_modified=datetime.now(UTC),
|
||||
metadata={},
|
||||
),
|
||||
]
|
||||
mock_storage.delete.return_value = None
|
||||
|
||||
# Delete from 1.0
|
||||
result = service.delete(ObjectKey(bucket="test-bucket", key="releases/1.0/app.zip.delta"))
|
||||
|
||||
# Should clean up only 1.0/reference.bin
|
||||
assert result["cleaned_reference"] == "releases/1.0/reference.bin"
|
||||
|
||||
# Verify correct files deleted
|
||||
delete_calls = [call[0][0] for call in mock_storage.delete.call_args_list]
|
||||
assert "test-bucket/releases/1.0/app.zip.delta" in delete_calls
|
||||
assert "test-bucket/releases/1.0/reference.bin" in delete_calls
|
||||
|
||||
|
||||
class TestRecursiveDeleteCleanup:
|
||||
"""Test that recursive delete properly cleans up references."""
|
||||
|
||||
def test_recursive_delete_reference_cleanup_already_works(self):
|
||||
"""Verify existing recursive delete reference cleanup is working."""
|
||||
service = create_service()
|
||||
mock_storage = Mock()
|
||||
service.storage = mock_storage
|
||||
|
||||
# Mock objects in deltaspace
|
||||
mock_storage.list.return_value = [
|
||||
ObjectHead(
|
||||
key="data/app.zip.delta",
|
||||
size=1000,
|
||||
etag="1",
|
||||
last_modified=datetime.now(UTC),
|
||||
metadata={},
|
||||
),
|
||||
ObjectHead(
|
||||
key="data/reference.bin",
|
||||
size=50000,
|
||||
etag="2",
|
||||
last_modified=datetime.now(UTC),
|
||||
metadata={},
|
||||
),
|
||||
]
|
||||
|
||||
mock_storage.head.return_value = None
|
||||
mock_storage.delete.return_value = None
|
||||
|
||||
result = service.delete_recursive("test-bucket", "data/")
|
||||
|
||||
# Should delete both delta and reference
|
||||
assert result["deleted_count"] == 2
|
||||
assert result["deltas_deleted"] == 1
|
||||
assert result["references_deleted"] == 1
|
||||
|
||||
|
||||
if __name__ == "__main__":
|
||||
pytest.main([__file__, "-v"])
|
||||
@@ -286,6 +286,7 @@ class TestRecursiveDeleteReferenceCleanup:
|
||||
last_modified=None,
|
||||
metadata={"original_name": "file.zip"},
|
||||
)
|
||||
mock_storage.list.return_value = [] # No other deltas remain
|
||||
mock_storage.delete.return_value = None
|
||||
|
||||
# Test single delete
|
||||
|
||||
Reference in New Issue
Block a user