[PR #840] [CLOSED] Better handling around grep/awk #942

New Issue

2025-12-29T02:18:39+01:00

adam commented

2025-12-29 02:18:39 +01:00

📋 Pull Request Information

Original PR: https://github.com/dehydrated-io/dehydrated/pull/840
Author: @bahamat
Created: 9/21/2021
Status: ❌ Closed

Base: master ← Head: issue-839

📝 Commits (1)

3e063cc Better handling around grep/awk

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 dehydrated (+2 -2)

📄 Description

This fixes #839.

Test egrep -ao instead of just -o to avoid selecting egrep when -a is not supported (i.e., gnu-grep egrep is not available)
Use awk instead of gawk. gawk doesn't support the escape sequence passed, so it wouldn't work anyway. But Non-GNU systems will usually have a different flavor of awk where the escape sequence does work.

This has been tested on:

CentOS 7
CentOS 8
Debian 10
FreeBSD
illumos (SmartOS)
Ubuntu 20.04

I can also test on others if that's helpful.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dehydrated-io/dehydrated/pull/840 **Author:** [@bahamat](https://github.com/bahamat) **Created:** 9/21/2021 **Status:** ❌ Closed **Base:** `master` ← **Head:** `issue-839` --- ### 📝 Commits (1) - [`3e063cc`](https://github.com/dehydrated-io/dehydrated/commit/3e063cc41cb03eada7ed7e56577db8b0c584d9fa) Better handling around grep/awk ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `dehydrated` (+2 -2) </details> ### 📄 Description This fixes #839. * Test `egrep -ao` instead of just `-o` to avoid selecting `egrep` when `-a` is not supported (i.e., gnu-grep egrep is not available) * Use `awk` instead of `gawk`. `gawk` doesn't support the escape sequence passed, so it wouldn't work anyway. But Non-GNU systems will usually have a different flavor of awk where the escape sequence *does* work. This has been tested on: * CentOS 7 * CentOS 8 * Debian 10 * FreeBSD * illumos (SmartOS) * Ubuntu 20.04 I can also test on others if that's helpful. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-29 02:18:39 +01:00

adam closed this issue

2025-12-29 02:18:39 +01:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/dehydrated#942