[PR #727] [MERGED] Fix account URL #907

New Issue

adam · 2025-12-29T01:29:57+01:00

adam commented

2025-12-29 01:29:57 +01:00

📋 Pull Request Information

Original PR: https://github.com/dehydrated-io/dehydrated/pull/727
Author: @Rogdham
Created: 3/30/2020
Status: ✅ Merged
Merged: 4/6/2020
Merged by: @lukas2511

Base: master ← Head: fix_account_url

📝 Commits (1)

dbb0ef1 Move from account ID to account URL

📊 Changes

1 file changed (+11 additions, -12 deletions)

View changed files

📝 dehydrated (+11 -12)

📄 Description

Fixes #671. Note that I did not change the ACMEv1 code at all, not sure what that version of the protocol is supposed to do.

We store the account URL on account creation in the account_id.json file.

When reading the file, if the attribute is missing, we fall back to previous behaviour, with a warning message.

Per https://tools.ietf.org/html/rfc8555#section-7.3

The server returns this account object in a 201 (Created) response, with the account URL in a Location header field. The account URL is used as the "kid" value in the JWS authenticating subsequent requests by this account (see Section 6.2). The account URL is also used for requests for management actions on this account, as described below.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dehydrated-io/dehydrated/pull/727 **Author:** [@Rogdham](https://github.com/Rogdham) **Created:** 3/30/2020 **Status:** ✅ Merged **Merged:** 4/6/2020 **Merged by:** [@lukas2511](https://github.com/lukas2511) **Base:** `master` ← **Head:** `fix_account_url` --- ### 📝 Commits (1) - [`dbb0ef1`](https://github.com/dehydrated-io/dehydrated/commit/dbb0ef1ce1a93a20fe1cc532adbdf676cb14c3d3) Move from account ID to account URL ### 📊 Changes **1 file changed** (+11 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `dehydrated` (+11 -12) </details> ### 📄 Description Fixes #671. Note that I did not change the ACMEv1 code at all, not sure what that version of the protocol is supposed to do. We store the account URL on account creation in the `account_id.json` file. When reading the file, if the attribute is missing, we fall back to previous behaviour, with a warning message. --- Per https://tools.ietf.org/html/rfc8555#section-7.3 > The server returns this account object in a 201 (Created) response, with the account URL in a Location header field. The account URL is used as the "kid" value in the JWS authenticating subsequent requests by this account (see Section 6.2). The account URL is also used for requests for management actions on this account, as described below. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-29 01:29:57 +01:00

adam closed this issue

2025-12-29 01:29:57 +01:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/dehydrated#907