[PR #669] [CLOSED] changing how we fetch the account id from the Location #892

New Issue

adam · 2025-12-29T01:29:51+01:00

adam commented

2025-12-29 01:29:51 +01:00

📋 Pull Request Information

Original PR: https://github.com/dehydrated-io/dehydrated/pull/669
Author: @aloopkin
Created: 9/3/2019
Status: ❌ Closed

Base: master ← Head: master

📝 Commits (5)

39a5d3c Update dehydrated
42f920a Merge pull request #1 from aloopkin/aloopkin-patch-1
3756d4a reverting
37593e2 Merge remote-tracking branch 'upstream/master'
6cb87a9 changing how we fetch the account id from the Location

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 dehydrated (+1 -1)

📄 Description

Relying on the account id being the last element in the URL could be unreliable... and is not working with some ACMEv2 implementations.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dehydrated-io/dehydrated/pull/669 **Author:** [@aloopkin](https://github.com/aloopkin) **Created:** 9/3/2019 **Status:** ❌ Closed **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (5) - [`39a5d3c`](https://github.com/dehydrated-io/dehydrated/commit/39a5d3ca0f9adf8473abca76c506ac5543e3860f) Update dehydrated - [`42f920a`](https://github.com/dehydrated-io/dehydrated/commit/42f920a539fffaaa7b5fc41e42ad2be2169b2122) Merge pull request #1 from aloopkin/aloopkin-patch-1 - [`3756d4a`](https://github.com/dehydrated-io/dehydrated/commit/3756d4a39e3621562f29c3cace8674087b8e599d) reverting - [`37593e2`](https://github.com/dehydrated-io/dehydrated/commit/37593e218d61f4ae2b80a7e17cc5062034a71b3f) Merge remote-tracking branch 'upstream/master' - [`6cb87a9`](https://github.com/dehydrated-io/dehydrated/commit/6cb87a95af70196cf16ca0ef6302f1e4e7763846) changing how we fetch the account id from the Location ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `dehydrated` (+1 -1) </details> ### 📄 Description Relying on the account id being the last element in the URL could be unreliable... and is not working with some ACMEv2 implementations. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-29 01:29:51 +01:00

adam closed this issue

2025-12-29 01:29:52 +01:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/dehydrated#892