[PR #666] [CLOSED] Only check existing certs when necessary #891

New Issue

adam · 2025-12-29T01:29:51+01:00

adam commented

2025-12-29 01:29:51 +01:00

📋 Pull Request Information

Original PR: https://github.com/dehydrated-io/dehydrated/pull/666
Author: @stefaang
Created: 8/26/2019
Status: ❌ Closed

Base: master ← Head: master

📝 Commits (1)

16a89f6 Only check existing certs when necessary

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 dehydrated (+1 -1)

📄 Description

Fixes https://github.com/lukas2511/dehydrated/issues/230

The expiry date check could be skipped too.

Some extra info:
I tried running dehydrated on an entware installation + lighttpd webserver based on this.
Unfortunately, the openssl package in entware doesn't support the -extensions req_ext flag, hence there's no DNS section in generated keys.
I tried running the script without any certificates, but lighttpd doesn't want to start when the certs in its config do not exist. Dehydrated doesn't want to generate certs when it fails to parse the DNS section in existing certs. A bit of a chicken/egg situation.

Hence, when forcing to generate certs anyway, do not parse the existing certs.. the main goal of that section is to enable the force flag anyway.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dehydrated-io/dehydrated/pull/666 **Author:** [@stefaang](https://github.com/stefaang) **Created:** 8/26/2019 **Status:** ❌ Closed **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`16a89f6`](https://github.com/dehydrated-io/dehydrated/commit/16a89f6ea657abb546e21c5cfaeddd7d31b148ac) Only check existing certs when necessary ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `dehydrated` (+1 -1) </details> ### 📄 Description Fixes https://github.com/lukas2511/dehydrated/issues/230 The expiry date check could be skipped too. Some extra info: I tried running dehydrated on an entware installation + lighttpd webserver based on [this](https://redmine.lighttpd.net/projects/lighttpd/wiki/HowToSimpleSSL#Lets-Encrypt-bootstrap-using-TLS-ALPN-01-verification-challenge-and-dehydrated-with-lighttpd-1453). Unfortunately, the openssl package in entware doesn't support the -extensions req_ext flag, hence there's no DNS section in generated keys. I tried running the script without any certificates, but lighttpd doesn't want to start when the certs in its config do not exist. Dehydrated doesn't want to generate certs when it fails to parse the DNS section in existing certs. A bit of a chicken/egg situation. Hence, when forcing to generate certs anyway, do not parse the existing certs.. the main goal of that section is to enable the force flag anyway. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-29 01:29:51 +01:00

adam closed this issue

2025-12-29 01:29:51 +01:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/dehydrated#891