[PR #667] [CLOSED] cleanup: also do cleanup if symlink is broken #890

New Issue

2025-12-29T01:29:50+01:00

adam commented

2025-12-29 01:29:50 +01:00

📋 Pull Request Information

Original PR: https://github.com/dehydrated-io/dehydrated/pull/667
Author: @arnout
Created: 8/30/2019
Status: ❌ Closed

Base: master ← Head: master

📝 Commits (1)

2e00c8e cleanup: also do cleanup if symlink is broken

📊 Changes

1 file changed (+7 additions, -5 deletions)

View changed files

📝 dehydrated (+7 -5)

📄 Description

The cleanup command skips filetypes for which the symlink is broken or
doesn't exist. However, if dehydrated fails, we may end up in exactly
the situation that the symlink doesn't exist (yet). If dehydrated fails
repeatedly, we may end up with a lot of old cert.csr, cert.pem and
privkey.pem files, so we really want to be able to clean them up.

Remove all files if the symlink is broken/missing, instead of skipping
those files.

Signed-off-by: Arnout Vandecappelle (Essensium/Mind) arnout@mind.be

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dehydrated-io/dehydrated/pull/667 **Author:** [@arnout](https://github.com/arnout) **Created:** 8/30/2019 **Status:** ❌ Closed **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`2e00c8e`](https://github.com/dehydrated-io/dehydrated/commit/2e00c8ea4e4deb45b4501f7ff9dab73974d94ce7) cleanup: also do cleanup if symlink is broken ### 📊 Changes **1 file changed** (+7 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `dehydrated` (+7 -5) </details> ### 📄 Description The cleanup command skips filetypes for which the symlink is broken or doesn't exist. However, if dehydrated fails, we may end up in exactly the situation that the symlink doesn't exist (yet). If dehydrated fails repeatedly, we may end up with a lot of old cert.csr, cert.pem and privkey.pem files, so we really want to be able to clean them up. Remove all files if the symlink is broken/missing, instead of skipping those files. Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-29 01:29:50 +01:00

adam closed this issue

2025-12-29 01:29:50 +01:00

adam referenced this issue

2025-12-29 02:18:43 +01:00

[PR #890] [CLOSED] egrep -> grep -E #955

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/dehydrated#890