[PR #662] Split long lines in domains.txt (revised) #888

New Issue

adam · 2025-12-29T01:29:50+01:00

adam commented

2025-12-29 01:29:50 +01:00

📋 Pull Request Information

Original PR: https://github.com/dehydrated-io/dehydrated/pull/662
Author: @redneck-f25
Created: 8/16/2019
Status: 🔄 Open

Base: master ← Head: feature-split_domain_lines

📝 Commits (4)

b2cf61a Split long lines in domain.txt
6bf67bd Ensure separating space.
68cbb62 Revert last commit (Ensure separating space).
4c75592 Empty lines and lines starting with a hash and ending without backslash end the block

📊 Changes

1 file changed (+11 additions, -1 deletions)

View changed files

📝 dehydrated (+11 -1)

📄 Description

According to your comment (https://github.com/lukas2511/dehydrated/pull/642#issuecomment-521625332) I revised my modifications.

There is a script to test the parsing of domains.txt at https://gist.github.com/redneck-f25/51ba79d0d3ef8a43a2eacffb672fd9d2.

Since many NAS- and Administration-Systems (e.g. Synology Diskstation and Plesk) have a plugin for LE for "simple" configurations it is the task of Dehydrated (which is great, btw) to handle more comlicated situations.

Thanks for your great work.

# example domains.txt
draft.example.com alias.example.com
draft1.example.com\
alias1.draft1.example.com\
# disabled: alias2.draft1.example.com\
alias3.draft1.example.com\

draft2.example.com \
  alias1.draft2.example.com \
  alias2.draft2.example.com \
  # disabled: alias3.draft2.example.com
draft3.example.com                  \
  alias1.draft3.example.com      \
  alias2.draft3.example.com      \
  # disabled: alias3.draft3.example.com
# end of domains.txt

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dehydrated-io/dehydrated/pull/662 **Author:** [@redneck-f25](https://github.com/redneck-f25) **Created:** 8/16/2019 **Status:** 🔄 Open **Base:** `master` ← **Head:** `feature-split_domain_lines` --- ### 📝 Commits (4) - [`b2cf61a`](https://github.com/dehydrated-io/dehydrated/commit/b2cf61a330fd978c823e8494d1e2cd86c907e133) Split long lines in domain.txt - [`6bf67bd`](https://github.com/dehydrated-io/dehydrated/commit/6bf67bd8e604bd6fe1e23cd69a40398ca9bfc9e7) Ensure separating space. - [`68cbb62`](https://github.com/dehydrated-io/dehydrated/commit/68cbb620fbc8a375a8ef2b534aef489ae6368bad) Revert last commit (Ensure separating space). - [`4c75592`](https://github.com/dehydrated-io/dehydrated/commit/4c755929814ca8611eb15af19ee7895e756f2b5c) Empty lines and lines starting with a hash and ending without backslash end the block ### 📊 Changes **1 file changed** (+11 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `dehydrated` (+11 -1) </details> ### 📄 Description According to your comment (https://github.com/lukas2511/dehydrated/pull/642#issuecomment-521625332) I revised my modifications. There is a script to test the parsing of domains.txt at https://gist.github.com/redneck-f25/51ba79d0d3ef8a43a2eacffb672fd9d2. Since many NAS- and Administration-Systems (e.g. Synology Diskstation and Plesk) have a plugin for LE for "simple" configurations it is the task of Dehydrated (which is great, btw) to handle more comlicated situations. Thanks for your great work. ``` # example domains.txt draft.example.com alias.example.com draft1.example.com\ alias1.draft1.example.com\ # disabled: alias2.draft1.example.com\ alias3.draft1.example.com\ draft2.example.com \ alias1.draft2.example.com \ alias2.draft2.example.com \ # disabled: alias3.draft2.example.com draft3.example.com \ alias1.draft3.example.com \ alias2.draft3.example.com \ # disabled: alias3.draft3.example.com # end of domains.txt ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-29 01:29:50 +01:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/dehydrated#888