[PR #611] [CLOSED] Defer verification of domain-specific config options for --cron #872

New Issue

2025-12-29T01:29:45+01:00

adam commented

2025-12-29 01:29:45 +01:00

📋 Pull Request Information

Original PR: https://github.com/dehydrated-io/dehydrated/pull/611
Author: @chrisnovakovic
Created: 12/7/2018
Status: ❌ Closed

Base: master ← Head: defer-verify-config

📝 Commits (1)

c27783b Defer verification of domain-specific config options for --cron

📊 Changes

1 file changed (+35 additions, -10 deletions)

View changed files

📝 dehydrated (+35 -10)

📄 Description

The --cron option supports the loading of domain-specific config files (via the DOMAINS_D option in the global config file), but all configuration options are verified before the domain-specific config file is loaded, meaning that an otherwise-valid configuration split across both the global and domain-specific config files raises an error. I first ran into this problem when I set a domain-specific WELLKNOWN path and no value for WELLKNOWN on a system where the default directory /var/www/dehydrated didn't exist, and the resulting behaviour felt counter-intuitive after I'd specifically requested a particular WELLKNOWN path for that domain:

# dehydrated --cron --keep-going
# INFO: Using main config file /etc/dehydrated/config
 + Creating chain cache directory /etc/dehydrated/chains
Processing domain.com with alternative names: a.domain.com b.domain.com 
 + Creating new directory /etc/dehydrated/certs/domain.com ...
ERROR: WELLKNOWN directory doesn't exist, please create /var/www/dehydrated and set appropriate permissions.

This PR defers verification of options that may be included in domain-specific config files until after any domain-specific config file has been read.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dehydrated-io/dehydrated/pull/611 **Author:** [@chrisnovakovic](https://github.com/chrisnovakovic) **Created:** 12/7/2018 **Status:** ❌ Closed **Base:** `master` ← **Head:** `defer-verify-config` --- ### 📝 Commits (1) - [`c27783b`](https://github.com/dehydrated-io/dehydrated/commit/c27783bac85853ed0c05b2e50c49415fb12d93ee) Defer verification of domain-specific config options for --cron ### 📊 Changes **1 file changed** (+35 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `dehydrated` (+35 -10) </details> ### 📄 Description The `--cron` option supports the loading of domain-specific config files (via the `DOMAINS_D` option in the global config file), but all configuration options are verified before the domain-specific config file is loaded, meaning that an otherwise-valid configuration split across both the global and domain-specific config files raises an error. I first ran into this problem when I set a domain-specific `WELLKNOWN` path and no value for `WELLKNOWN` on a system where the default directory `/var/www/dehydrated` didn't exist, and the resulting behaviour felt counter-intuitive after I'd specifically requested a particular `WELLKNOWN` path for that domain: ``` # dehydrated --cron --keep-going # INFO: Using main config file /etc/dehydrated/config + Creating chain cache directory /etc/dehydrated/chains Processing domain.com with alternative names: a.domain.com b.domain.com + Creating new directory /etc/dehydrated/certs/domain.com ... ERROR: WELLKNOWN directory doesn't exist, please create /var/www/dehydrated and set appropriate permissions. ``` This PR defers verification of options that may be included in domain-specific config files until after any domain-specific config file has been read. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-29 01:29:45 +01:00

adam closed this issue

2025-12-29 01:29:46 +01:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/dehydrated#872