[PR #557] [CLOSED] New hook to be called before challenge validation #864

New Issue

adam · 2025-12-29T01:29:43+01:00

adam commented

2025-12-29 01:29:43 +01:00

📋 Pull Request Information

Original PR: https://github.com/dehydrated-io/dehydrated/pull/557
Author: @CTassisF
Created: 5/3/2018
Status: ❌ Closed

Base: master ← Head: master

📝 Commits (2)

79fe907 New hook to be called before challenge validation
fc257fd It is probably better to call before_challenge_validation with the same arguments as deploy_challenge

📊 Changes

1 file changed (+13 additions, -0 deletions)

View changed files

📝 dehydrated (+13 -0)

📄 Description

After adding/removing resource records on ClouDNS (and probably other authoritative DNS providers, I guess) you have to wait while the new zone is propagated across all of their servers. This is a time-consuming process and it isn't really predictable, luckily ClouDNS offers a way to check if the zone is updated.

Now that deploy_challenge is done for all -d domains in sequence it would be great to have a hook that is called after all deploy_challenges but before these challenges are validated. That way we can make deploy_challenge add all TXT records asynchronously and call just one loop in before_challenge_validation to wait while the zone isn't updated across all ClouDNS servers.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dehydrated-io/dehydrated/pull/557 **Author:** [@CTassisF](https://github.com/CTassisF) **Created:** 5/3/2018 **Status:** ❌ Closed **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (2) - [`79fe907`](https://github.com/dehydrated-io/dehydrated/commit/79fe907ff71165773a6f6027b12c2857f235b432) New hook to be called before challenge validation - [`fc257fd`](https://github.com/dehydrated-io/dehydrated/commit/fc257fd111ee29397f9e820a2690edcc97ff4161) It is probably better to call before_challenge_validation with the same arguments as deploy_challenge ### 📊 Changes **1 file changed** (+13 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `dehydrated` (+13 -0) </details> ### 📄 Description After adding/removing resource records on ClouDNS (and probably other authoritative DNS providers, I guess) you have to wait while the new zone is propagated across all of their servers. This is a time-consuming process and it isn't really predictable, luckily ClouDNS offers a way to check if the zone [is updated](https://www.cloudns.net/wiki/article/54/). Now that `deploy_challenge` is done for all `-d domain`s in sequence it would be great to have a hook that is called after all `deploy_challenge`s but before these challenges are validated. That way we can make `deploy_challenge` add all TXT records asynchronously and call just one loop in `before_challenge_validation` to wait while the zone isn't updated across all ClouDNS servers. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-29 01:29:43 +01:00

adam closed this issue

2025-12-29 01:29:43 +01:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/dehydrated#864