starred/dehydrated
1
0
Fork 0
mirror of https://github.com/dehydrated-io/dehydrated.git synced 2026-03-03 14:40:00 +01:00
Code Issues 79 Packages Projects Releases 10 Wiki Activity

change PRIVATE_KEY to ACCOUNT_KEY #85

New Issue
Closed
opened 2025-12-29 00:24:31 +01:00 by adam · 3 comments
adam commented 2025-12-29 00:24:31 +01:00
Owner
Copy Link

Originally created by @reardonia on GitHub (Apr 24, 2016).

Just a recommendation:

the use of the term "PRIVATE_KEY" is overloaded; change to ACCOUNT_KEY where appropriate, avoid confusion with privkey, PRIVATE_KEY_RENEW, and the like

Originally created by @reardonia on GitHub (Apr 24, 2016). Just a recommendation: the use of the term "PRIVATE_KEY" is overloaded; change to ACCOUNT_KEY where appropriate, avoid confusion with privkey, PRIVATE_KEY_RENEW, and the like
adam closed this issue 2025-12-29 00:24:32 +01:00
adam commented 2025-12-29 00:24:33 +01:00
Author
Owner
Copy Link

@lukas2511 commented on GitHub (Apr 24, 2016):

I agree, changed this in the mentioned commit. Thanks.

@lukas2511 commented on GitHub (Apr 24, 2016): I agree, changed this in the mentioned commit. Thanks.
adam commented 2025-12-29 00:24:33 +01:00
Author
Owner
Copy Link

@Robby- commented on GitHub (Apr 26, 2016):

How about also changing the default filenames private_key.json/pem to account_key.json/pem while at it?

@Robby- commented on GitHub (Apr 26, 2016): How about also changing the default filenames private_key.json/pem to account_key.json/pem while at it?
adam commented 2025-12-29 00:24:35 +01:00
Author
Owner
Copy Link

@lukas2511 commented on GitHub (Apr 26, 2016):

@Robby- I'd like to avoid that since this would silently impact a lot of setups... :-/

@lukas2511 commented on GitHub (Apr 26, 2016): @Robby- I'd like to avoid that since this would silently impact a lot of setups... :-/
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Complicated
bug
enhancement
help wanted
pull-request
Mirrored from GitHub Pull Request
 suggestions wanted
testing
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/dehydrated#85
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?