[PR #293] [MERGED] Skip challenge for already validated domains #791

New Issue

adam · 2025-12-29T01:29:19+01:00

adam commented

2025-12-29 01:29:19 +01:00

📋 Pull Request Information

Original PR: https://github.com/dehydrated-io/dehydrated/pull/293
Author: @sth
Created: 10/8/2016
Status: ✅ Merged
Merged: 12/18/2016
Merged by: @lukas2511

Base: master ← Head: skip-validated

📝 Commits (2)

c5f6045 skip challenge for already validated domains
e49c7df only call deploy_challenge hook if there is work

📊 Changes

1 file changed (+22 additions, -5 deletions)

View changed files

📝 dehydrated (+22 -5)

📄 Description

For domains that are already validated we don't need to fulfill further challenges.

If a challenge request for a domain returns "status": "valid" no further validation is required and further processing is skipped. Skipping this further processing also avoids parsing problems when the challenge response contains additional fields, for example describing a previous successful DNS challenge.

The new variable ${challenge_altnames} is used to keep track of the names that are not validated yet and still need do the challenge. When later iterating over this possibly empty array a :0 substring expansion has to be used to avoid bash complaining about an unbound variable (it treats empty arrays as unset).

This solves the same problem as pull request #283, hopefully in a more robust way.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dehydrated-io/dehydrated/pull/293 **Author:** [@sth](https://github.com/sth) **Created:** 10/8/2016 **Status:** ✅ Merged **Merged:** 12/18/2016 **Merged by:** [@lukas2511](https://github.com/lukas2511) **Base:** `master` ← **Head:** `skip-validated` --- ### 📝 Commits (2) - [`c5f6045`](https://github.com/dehydrated-io/dehydrated/commit/c5f6045a325b850c19a3d0afe0d768f97ca3c18f) skip challenge for already validated domains - [`e49c7df`](https://github.com/dehydrated-io/dehydrated/commit/e49c7dfbf1d4a3bdca1c12560875ace2bc04a38a) only call deploy_challenge hook if there is work ### 📊 Changes **1 file changed** (+22 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `dehydrated` (+22 -5) </details> ### 📄 Description For domains that are already validated we don't need to fulfill further challenges. If a challenge request for a domain returns `"status": "valid"` no further validation is required and further processing is skipped. Skipping this further processing also avoids parsing problems when the challenge response contains additional fields, for example describing a previous successful DNS challenge. The new variable `${challenge_altnames}` is used to keep track of the names that are not validated yet and still need do the challenge. When later iterating over this possibly empty array a `:0` substring expansion has to be used to avoid bash complaining about an unbound variable (it treats empty arrays as unset). This solves the same problem as pull request #283, hopefully in a more robust way. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-29 01:29:19 +01:00

adam closed this issue

2025-12-29 01:29:19 +01:00

adam referenced this issue

2025-12-29 01:30:03 +01:00

[PR #791] [CLOSED] fix parsing cert-specific config #927

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/dehydrated#791