starred/dehydrated
1
0
Fork 0
mirror of https://github.com/dehydrated-io/dehydrated.git synced 2026-09-02 17:37:12 +02:00
Code Issues 79 Packages Projects Releases 10 Wiki Activity

[PR #283] [CLOSED] Fix request new certificate if authorization valid #785

New Issue
Closed
opened 2025-12-29 01:29:09 +01:00 by adam · 0 comments
adam commented 2025-12-29 01:29:09 +01:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/dehydrated-io/dehydrated/pull/283
Author: @dennisschuerholz
Created: 9/20/2016
Status: ❌ Closed

Base: master ← Head: master

📝 Commits (2)

  • 28ba07d Fix request new certificate if authorization valid
  • 01f26f5 fix unbound variable

📊 Changes

1 file changed (+14 additions, -3 deletions)

View changed files

📝 dehydrated (+14 -3)

📄 Description

I just had an issue after switching from dns based challenges to http (see serverfault and le-community) so I made this quick fix which allowed me to use dehydrated again.

The change in Line 464(old)/468(new) corresponds to the "bigger" answer as mentioned in the serverfault post. Indeed it may not longer be necessary as I implemented a "quick escape" before extracting the challenges but I would leave it there - just in case.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/dehydrated-io/dehydrated/pull/283 **Author:** [@dennisschuerholz](https://github.com/dennisschuerholz) **Created:** 9/20/2016 **Status:** ❌ Closed **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (2) - [`28ba07d`](https://github.com/dehydrated-io/dehydrated/commit/28ba07d26b37bd63e7764080ab11d206c5d1ccda) Fix request new certificate if authorization valid - [`01f26f5`](https://github.com/dehydrated-io/dehydrated/commit/01f26f53ea35d3f19c04b8ebd1859dc3107f3492) fix unbound variable ### 📊 Changes **1 file changed** (+14 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `dehydrated` (+14 -3) </details> ### 📄 Description I just had an issue after switching from dns based challenges to http (see [serverfault](https://serverfault.com/questions/804030/letsencrypt-certificate-renewal-switching-from-dns-to-http) and [le-community](https://community.letsencrypt.org/t/certificate-renewal-switching-from-dns-to-http/20030?u=dennisschuerholz)) so I made this quick fix which allowed me to use dehydrated again. The change in Line 464(old)/468(new) corresponds to the "bigger" answer as mentioned in the serverfault post. Indeed it may not longer be necessary as I implemented a "quick escape" before extracting the challenges but I would leave it there - just in case. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 01:29:09 +01:00
adam closed this issue 2025-12-29 01:29:09 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Complicated
bug
enhancement
help wanted
pull-request
Mirrored from GitHub Pull Request
 suggestions wanted
testing
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/dehydrated#785