starred/dehydrated
1
0
Fork 0
mirror of https://github.com/dehydrated-io/dehydrated.git synced 2026-09-02 17:17:11 +02:00
Code Issues 79 Packages Projects Releases 10 Wiki Activity

[PR #266] [CLOSED] Fix config logic for revoke command. #778

New Issue
Closed
opened 2025-12-29 01:29:06 +01:00 by adam · 0 comments
adam commented 2025-12-29 01:29:06 +01:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/dehydrated-io/dehydrated/pull/266
Author: @alexionescu
Created: 9/1/2016
Status: ❌ Closed

Base: master ← Head: revoke-config-logic

📝 Commits (1)

  • 65e7f37 Fix config logic for revoke command.

📊 Changes

1 file changed (+3 additions, -0 deletions)

View changed files

📝 letsencrypt.sh (+3 -0)

📄 Description

I noticed that when I wanted to revoke a certificate it would complain about either not having a .well-known directory to perform a http challenge. Using dns-01 it would say there isn't a hook given. Neither of these are required to revoke a certificate so for the config check it should short circuit out of the method.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/dehydrated-io/dehydrated/pull/266 **Author:** [@alexionescu](https://github.com/alexionescu) **Created:** 9/1/2016 **Status:** ❌ Closed **Base:** `master` ← **Head:** `revoke-config-logic` --- ### 📝 Commits (1) - [`65e7f37`](https://github.com/dehydrated-io/dehydrated/commit/65e7f37dd358c2678b244c11de14805d271ed460) Fix config logic for revoke command. ### 📊 Changes **1 file changed** (+3 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `letsencrypt.sh` (+3 -0) </details> ### 📄 Description I noticed that when I wanted to revoke a certificate it would complain about either not having a .well-known directory to perform a http challenge. Using dns-01 it would say there isn't a hook given. Neither of these are required to revoke a certificate so for the config check it should short circuit out of the method. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 01:29:06 +01:00
adam closed this issue 2025-12-29 01:29:07 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Complicated
bug
enhancement
help wanted
pull-request
Mirrored from GitHub Pull Request
 suggestions wanted
testing
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/dehydrated#778