starred/dehydrated
1
0
Fork 0
mirror of https://github.com/dehydrated-io/dehydrated.git synced 2026-01-11 22:30:44 +01:00
Code Issues 79 Packages Projects Releases 10 Wiki Activity

[PR #225] [CLOSED] Fix domain name check from certificate. #762

New Issue
Closed
opened 2025-12-29 01:29:01 +01:00 by adam · 0 comments
adam commented 2025-12-29 01:29:01 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/dehydrated-io/dehydrated/pull/225
Author: @ergonlogic
Created: 6/17/2016
Status: ❌ Closed

Base: master ← Head: domain_check_fix

📝 Commits (1)

  • 7e27d6b Fix domain name check from certificate.

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 letsencrypt.sh (+1 -1)

📄 Description

It looks like Let's Encrypt changed the way they generate certificates early this morning. There are no longer "DNS" lines, breaking the check to extract the cert name.

We (@colans & I) just switched to looking in the CN. We haven't tested with alt names yet, but will be shortly.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/dehydrated-io/dehydrated/pull/225 **Author:** [@ergonlogic](https://github.com/ergonlogic) **Created:** 6/17/2016 **Status:** ❌ Closed **Base:** `master` ← **Head:** `domain_check_fix` --- ### 📝 Commits (1) - [`7e27d6b`](https://github.com/dehydrated-io/dehydrated/commit/7e27d6bbbb2be928cb0d600b774edab97404a0d7) Fix domain name check from certificate. ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `letsencrypt.sh` (+1 -1) </details> ### 📄 Description It looks like Let's Encrypt changed the way they generate certificates early this morning. There are no longer "DNS" lines, breaking the check to extract the cert name. We (@colans & I) just switched to looking in the CN. We haven't tested with alt names yet, but will be shortly. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 01:29:01 +01:00
adam closed this issue 2025-12-29 01:29:01 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Complicated
bug
enhancement
help wanted
pull-request
Mirrored from GitHub Pull Request
 suggestions wanted
testing
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/dehydrated#762
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?