[PR #98] [MERGED] Respect configured BASEDIR for default values #710

New Issue

adam · 2025-12-29T01:28:35+01:00

adam commented

2025-12-29 01:28:35 +01:00

📋 Pull Request Information

Original PR: https://github.com/dehydrated-io/dehydrated/pull/98
Author: @ymc-dabe
Created: 1/21/2016
Status: ✅ Merged
Merged: 1/22/2016
Merged by: @lukas2511

Base: master ← Head: fix/configuring_BASEDIR_does_not_affect_built_in_defaults

📝 Commits (1)

9baf353 Respect configured BASEDIR for default values

📊 Changes

1 file changed (+7 additions, -3 deletions)

View changed files

📝 letsencrypt.sh (+7 -3)

📄 Description

Problem

If BASEDIR is set in config.sh, this does not modify the (default) values
of either PRIVATE_KEY, WELLKNOWN or LOCKFILE. One needs to manually specify
those three config variables in config.sh, if a different BASEDIR
should be used by letsencrypt.sh.

How to reproduce

Clone letsencrypt.sh to /tmp/
cd /tmp/ && git clone https://github.com/lukas2511/letsencrypt.sh.git

Provide the following /tmp/letsencrypt.sh/config.sh:

BASEDIR="/tmp"
#WELLKNOWN="${BASEDIR}/.acme-challenges"
#PRIVATE_KEY="${BASEDIR}/private_key.pem"

Run letsencrypt.sh with paramemetr -e
/tmp/letsencrypt.sh/letsencrypt.sh -e

Expected result (on Debian/jessie)

# letsencrypt.sh configuration
# INFO: Using config file /tmp/letsencrypt.sh/config.sh
declare -- CA="https://acme-v01.api.letsencrypt.org/directory"
declare -- LICENSE="https://letsencrypt.org/documents/LE-SA-v1.0.1-July-27-2015.pdf"
declare -- CHALLENGETYPE="http-01"
declare -- HOOK=""
declare -- RENEW_DAYS="30"
declare -- PRIVATE_KEY="/tmp/private_key.pem"
declare -- KEYSIZE="4096"
declare -- WELLKNOWN="/tmp/.acme-challenges"
declare -- PRIVATE_KEY_RENEW="no"
declare -- OPENSSL_CNF="/usr/lib/ssl/openssl.cnf"
declare -- CONTACT_EMAIL=""
declare -- LOCKFILE="/tmp/lock"

Actual result (on Debian/jessie)

# letsencrypt.sh configuration
# INFO: Using config file /tmp/letsencrypt.sh/config.sh
declare -- CA="https://acme-v01.api.letsencrypt.org/directory"
declare -- LICENSE="https://letsencrypt.org/documents/LE-SA-v1.0.1-July-27-2015.pdf"
declare -- CHALLENGETYPE="http-01"
declare -- HOOK=""
declare -- RENEW_DAYS="30"
declare -- PRIVATE_KEY="/tmp/letsencrypt.sh/private_key.pem"
declare -- KEYSIZE="4096"
declare -- WELLKNOWN="/tmp/letsencrypt.sh/.acme-challenges"
declare -- PRIVATE_KEY_RENEW="no"
declare -- OPENSSL_CNF="/usr/lib/ssl/openssl.cnf"
declare -- CONTACT_EMAIL=""
declare -- LOCKFILE="/tmp/letsencrypt.sh/lock"

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dehydrated-io/dehydrated/pull/98 **Author:** [@ymc-dabe](https://github.com/ymc-dabe) **Created:** 1/21/2016 **Status:** ✅ Merged **Merged:** 1/22/2016 **Merged by:** [@lukas2511](https://github.com/lukas2511) **Base:** `master` ← **Head:** `fix/configuring_BASEDIR_does_not_affect_built_in_defaults` --- ### 📝 Commits (1) - [`9baf353`](https://github.com/dehydrated-io/dehydrated/commit/9baf3532e54b21bb08bc196a1bf2471f59684c2d) Respect configured BASEDIR for default values ### 📊 Changes **1 file changed** (+7 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `letsencrypt.sh` (+7 -3) </details> ### 📄 Description # Problem If BASEDIR is set in config.sh, this does not modify the (default) values of either PRIVATE_KEY, WELLKNOWN or LOCKFILE. One needs to manually specify those three config variables in config.sh, if a different BASEDIR should be used by letsencrypt.sh. ## How to reproduce 1. Clone letsencrypt.sh to /tmp/ `cd /tmp/ && git clone https://github.com/lukas2511/letsencrypt.sh.git` 2. Provide the following /tmp/letsencrypt.sh/config.sh: ``` BASEDIR="/tmp" #WELLKNOWN="${BASEDIR}/.acme-challenges" #PRIVATE_KEY="${BASEDIR}/private_key.pem" ``` 3. Run letsencrypt.sh with paramemetr -e `/tmp/letsencrypt.sh/letsencrypt.sh -e` ### Expected result (on Debian/jessie) ``` # letsencrypt.sh configuration # INFO: Using config file /tmp/letsencrypt.sh/config.sh declare -- CA="https://acme-v01.api.letsencrypt.org/directory" declare -- LICENSE="https://letsencrypt.org/documents/LE-SA-v1.0.1-July-27-2015.pdf" declare -- CHALLENGETYPE="http-01" declare -- HOOK="" declare -- RENEW_DAYS="30" declare -- PRIVATE_KEY="/tmp/private_key.pem" declare -- KEYSIZE="4096" declare -- WELLKNOWN="/tmp/.acme-challenges" declare -- PRIVATE_KEY_RENEW="no" declare -- OPENSSL_CNF="/usr/lib/ssl/openssl.cnf" declare -- CONTACT_EMAIL="" declare -- LOCKFILE="/tmp/lock" ``` ### Actual result (on Debian/jessie) ``` # letsencrypt.sh configuration # INFO: Using config file /tmp/letsencrypt.sh/config.sh declare -- CA="https://acme-v01.api.letsencrypt.org/directory" declare -- LICENSE="https://letsencrypt.org/documents/LE-SA-v1.0.1-July-27-2015.pdf" declare -- CHALLENGETYPE="http-01" declare -- HOOK="" declare -- RENEW_DAYS="30" declare -- PRIVATE_KEY="/tmp/letsencrypt.sh/private_key.pem" declare -- KEYSIZE="4096" declare -- WELLKNOWN="/tmp/letsencrypt.sh/.acme-challenges" declare -- PRIVATE_KEY_RENEW="no" declare -- OPENSSL_CNF="/usr/lib/ssl/openssl.cnf" declare -- CONTACT_EMAIL="" declare -- LOCKFILE="/tmp/letsencrypt.sh/lock" ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-29 01:28:35 +01:00

adam closed this issue

2025-12-29 01:28:36 +01:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/dehydrated#710