starred/dehydrated
1
0
Fork 0
mirror of https://github.com/dehydrated-io/dehydrated.git synced 2026-01-13 15:13:33 +01:00
Code Issues 79 Packages Projects Releases 10 Wiki Activity

[PR #44] [MERGED] bugfix: keep configured PRIVATE_KEY #681

New Issue
Closed
opened 2025-12-29 01:28:25 +01:00 by adam · 0 comments
adam commented 2025-12-29 01:28:25 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/dehydrated-io/dehydrated/pull/44
Author: @digint
Created: 12/14/2015
Status: ✅ Merged
Merged: 12/14/2015
Merged by: @lukas2511

Base: master ← Head: bugfix_config_private_key

📝 Commits (1)

  • d24e531 bugfix: PRIVATE_KEY is now configurable in config.sh, don't alter this variable after set_defaults()

📊 Changes

1 file changed (+0 additions, -1 deletions)

View changed files

📝 letsencrypt.sh (+0 -1)

📄 Description

When overriding PRIVATE_KEY in config.sh, letsencrypt.sh erroneously changes it back to "${BASEDIR}/private_key.pem"

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/dehydrated-io/dehydrated/pull/44 **Author:** [@digint](https://github.com/digint) **Created:** 12/14/2015 **Status:** ✅ Merged **Merged:** 12/14/2015 **Merged by:** [@lukas2511](https://github.com/lukas2511) **Base:** `master` ← **Head:** `bugfix_config_private_key` --- ### 📝 Commits (1) - [`d24e531`](https://github.com/dehydrated-io/dehydrated/commit/d24e531afbd79beff56977f61d9452f95bddf6d8) bugfix: PRIVATE_KEY is now configurable in config.sh, don't alter this variable after set_defaults() ### 📊 Changes **1 file changed** (+0 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `letsencrypt.sh` (+0 -1) </details> ### 📄 Description When overriding PRIVATE_KEY in config.sh, letsencrypt.sh erroneously changes it back to "${BASEDIR}/private_key.pem" --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 01:28:25 +01:00
adam closed this issue 2025-12-29 01:28:25 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Complicated
bug
enhancement
help wanted
pull-request
Mirrored from GitHub Pull Request
 suggestions wanted
testing
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/dehydrated#681
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?