starred/dehydrated
1
0
Fork 0
mirror of https://github.com/dehydrated-io/dehydrated.git synced 2026-01-11 22:30:44 +01:00
Code Issues 79 Packages Projects Releases 10 Wiki Activity

[PR #39] [CLOSED] remove --sign in favor of two options "--force" and "--domain" #677

New Issue
Closed
opened 2025-12-29 01:28:25 +01:00 by adam · 0 comments
adam commented 2025-12-29 01:28:25 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/dehydrated-io/dehydrated/pull/39
Author: @germeier
Created: 12/12/2015
Status: ❌ Closed

Base: master ← Head: commands

📝 Commits (7)

📊 Changes

2 files changed (+51 additions, -36 deletions)

View changed files

📝 .travis.yml (+1 -1)
📝 letsencrypt.sh (+50 -35)

📄 Description

I really dislike the current "--sign (-s) domain.tld" command for several reasons:

  1. I want to be able to sign a certificate for testing purposes without having to add it to domains.txt. Even one with multiple SAN names!
  2. Even when specifying a domain on the command line I want to be informed that the certificate in questing is still within my definied useful time frame (e.g. longer valid than RENEW_DAYS) before really forcing a renew
  3. In the long run the letsencrypt.sh script should be able to work properly without any config files only using default values and command line options.

Therefor I suggest the following patch.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/dehydrated-io/dehydrated/pull/39 **Author:** [@germeier](https://github.com/germeier) **Created:** 12/12/2015 **Status:** ❌ Closed **Base:** `master` ← **Head:** `commands` --- ### 📝 Commits (7) - [`a59b07e`](https://github.com/dehydrated-io/dehydrated/commit/a59b07e1ad65e2f8c4d6c164e6721b6234ca4fce) remove --sign command in favor of two options --force and --domain - [`44f2eda`](https://github.com/dehydrated-io/dehydrated/commit/44f2eda5870d16a369ab8c9a065b107b2ce93e14) remove forgotten debug echo - [`dc7d3d6`](https://github.com/dehydrated-io/dehydrated/commit/dc7d3d659a01a5a41d1745a1f8f2842022e2c59b) remove forgotten case for removed command_sign - [`8d8a777`](https://github.com/dehydrated-io/dehydrated/commit/8d8a777fabd475578d3e080e03b8fcd95e1dac60) remove temp file if certificate request failed - [`3d2e3aa`](https://github.com/dehydrated-io/dehydrated/commit/3d2e3aa62f4b0e993ff244d866b7a044c79f15ff) --sign => --domain - [`b6a8843`](https://github.com/dehydrated-io/dehydrated/commit/b6a88438258b7726366fce7969be8f3ea69bf77e) remove --sign command in favor of two options --force and --domain - [`9532b35`](https://github.com/dehydrated-io/dehydrated/commit/9532b3512d2f8f66094da222d4417e7d7afcabb2) Merge branch 'commands' of https://github.com/germeier/letsencrypt.sh into commands ### 📊 Changes **2 files changed** (+51 additions, -36 deletions) <details> <summary>View changed files</summary> 📝 `.travis.yml` (+1 -1) 📝 `letsencrypt.sh` (+50 -35) </details> ### 📄 Description I really dislike the current "--sign (-s) domain.tld" command for several reasons: 1. I want to be able to sign a certificate for testing purposes without having to add it to domains.txt. Even one with multiple SAN names! 2. Even when specifying a domain on the command line I want to be informed that the certificate in questing is still within my definied useful time frame (e.g. longer valid than RENEW_DAYS) before really forcing a renew 3. In the long run the letsencrypt.sh script should be able to work properly without any config files only using default values and command line options. Therefor I suggest the following patch. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 01:28:25 +01:00
adam closed this issue 2025-12-29 01:28:25 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Complicated
bug
enhancement
help wanted
pull-request
Mirrored from GitHub Pull Request
 suggestions wanted
testing
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/dehydrated#677
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?