starred/dehydrated
1
0
Fork 0
mirror of https://github.com/dehydrated-io/dehydrated.git synced 2026-09-02 08:57:22 +02:00
Code Issues 79 Packages Projects Releases 10 Wiki Activity

[PR #6] [CLOSED] style: shellcheck #653

New Issue
Closed
opened 2025-12-29 01:28:18 +01:00 by adam · 0 comments
adam commented 2025-12-29 01:28:18 +01:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/dehydrated-io/dehydrated/pull/6
Author: @bdossantos
Created: 12/6/2015
Status: ❌ Closed

Base: master ← Head: style/shellcheck

📝 Commits (4)

  • e2d7a68 style: ... is preferred over [, test and /usr/bin/[.
  • f85a8f3 style: double quote to prevent globbing and word splitting
  • 23e520d style: don't use variables in the printf format string
  • 47762f2 style: read without -r mangles backslashes

📊 Changes

1 file changed (+20 additions, -15 deletions)

View changed files

📝 letsencrypt.sh (+20 -15)

📄 Description

Hi, this PR add some small style changes based on Shellcheck suggestions and Google Shell style guide.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/dehydrated-io/dehydrated/pull/6 **Author:** [@bdossantos](https://github.com/bdossantos) **Created:** 12/6/2015 **Status:** ❌ Closed **Base:** `master` ← **Head:** `style/shellcheck` --- ### 📝 Commits (4) - [`e2d7a68`](https://github.com/dehydrated-io/dehydrated/commit/e2d7a6834f88178f79b98ec47ab66f95521b91c3) style: [[ ... ]] is preferred over [, test and /usr/bin/[. - [`f85a8f3`](https://github.com/dehydrated-io/dehydrated/commit/f85a8f3fd499a14fa8e9085c8440dc158f435cd7) style: double quote to prevent globbing and word splitting - [`23e520d`](https://github.com/dehydrated-io/dehydrated/commit/23e520da06136589d0138b3881f5a0755a99033e) style: don't use variables in the printf format string - [`47762f2`](https://github.com/dehydrated-io/dehydrated/commit/47762f25c1e5164d639f4618e74c20874f3efbb4) style: read without -r mangles backslashes ### 📊 Changes **1 file changed** (+20 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `letsencrypt.sh` (+20 -15) </details> ### 📄 Description Hi, this PR add some small style changes based on [Shellcheck](https://github.com/koalaman/shellcheck) suggestions and [Google Shell style](https://google.github.io/styleguide/shell.xm) guide. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 01:28:18 +01:00
adam closed this issue 2025-12-29 01:28:18 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Complicated
bug
enhancement
help wanted
pull-request
Mirrored from GitHub Pull Request
 suggestions wanted
testing
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/dehydrated#653