mirror of
https://github.com/dehydrated-io/dehydrated.git
synced 2026-01-11 22:30:44 +01:00
Doesn't pass environment variables when run via sudo #622
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @haarp on GitHub (Aug 4, 2024).
Hey!
currently implementing dehydrated into my environment. I'm using lexicon for the dns-01 challenge.
As I'm using
DEHYDRATED_USERandDEHYDRATED_GROUP, sudo is used to run the script. However, sudo by default does not pass environment variables. As a result the clear and easy way of running dehydrated+lexicon using env variables as described here (with this hook) does not work.This can easily be mitigated by having sudo pass env variables. The
-E -Hoptions should be added.-Epasses env variables, while-Hsets a properHOME(which would be the wrong one from the env vars otherwise)I've been running it this way for a while now and see no issues. Would you consider making this the default?
Thanks a lot!
@lukas2511 commented on GitHub (Aug 4, 2024):
I've created a branch with a new config variable
DEHYDRATED_SUDO_ENVthat should allow this behaviour. Could you please check if that would solve your problem? https://github.com/dehydrated-io/dehydrated/tree/sudo-env@haarp commented on GitHub (Aug 4, 2024):
Hey, thanks for the super quick response! I've thrown
911a822on top of my dehydrated, addedDEHYDRATED_SUDO_ENV=yesto the config and gave it a test with--force --force-validation. It works, thanks a lot!Tho I wonder if a config variable is really necessary. Generally it's normal to keep the env when dropping privileges, e.g. daemons using
setsid/setgid. I'm trying to think of conditions where this env could be problematic. Apart from gross admin incompetence (unrelated secrets stored in env vars being leaked to a malicious hook) I can't think of any.@haarp commented on GitHub (Sep 13, 2025):
Hey, any news on this? Been using the patch in that branch for a while now and have no problems with it. Could you merge it? Cheers!