mirror of
https://github.com/dehydrated-io/dehydrated.git
synced 2026-01-13 15:13:33 +01:00
Stateless challenge-response #61
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @leonklingele on GitHub (Feb 16, 2016).
I found this other letsencrypt.sh project the other day: https://github.com/gheift/letsencrypt.sh
It handles the challenge-response mechanism quite nicely:
Replace
ACCOUNT_THUMBPRINTwith the (public) thumbprint of the private key, and everything else happens automagically, without having to create any files (like this project does in/var/www/letsencrypt)Are there any downsides to doing it this way?
@lukas2511 commented on GitHub (Feb 17, 2016):
I'm not sure, this way you'd always have your verification "files" in place, and an attacker having control of your account-key or a key with identical fingerprint (if that is possible) could sign certificates for all your domains.
@leonklingele commented on GitHub (Feb 17, 2016):
Well, if an attacker gets hold of your private key you have much worse problems to consider.
"Identical thumbprint" essentially means "same key pair", as the thumbprint is a SHA256 hash derived from the public key parts. A thumbprint hash collision with another key is so unlikely that the hash algorithm would be considered insecure. So not a problem at all.
@lukas2511 commented on GitHub (Feb 17, 2016):
There were already issues involving left-over signatures: https://github.com/letsencrypt/boulder/issues/604
Probably just a conceptional issue and nothing that was really exploited, but I really dislike that it would have worked in theory.
Also leaking private keys by accident is nothing new, people accidentally hosted private keys on their websites, on GitHub, or got them stolen through software exploits.
From some of the issues I've read on this repository I actually think some people are using this script inside of
/var/www/letsencrypt, basically having their private key a web-server configuration issue apart from being public...I agree that it would look cleaner, and be a lot easier since there is nothing that has to be moved around, but I really don't want to take this risk.
If you want to do this nothing stops you from doing this, you'd just have to extract your fingerprint once, but I dislike this as a "feature" (or configuration suggestion) for this script.