SANs broken since 31st #555

Closed
opened 2025-12-29 01:27:10 +01:00 by adam · 1 comment
Owner

Originally created by @paulkaweb on GitHub (Nov 1, 2021).

Hello, we seem to be having issues creating/renewing certs since your last commits.. the problem seems to stem from this change:

-    altnames="$( <<<"${altnames}" _sed -e 's/^[[:space:]]*//; s/, /'"'$'\n'"'/g' )"
+    altnames="$( <<<"${altnames}" _sed -e 's/^[[:space:]]*//; s/, /\'$'\n''/g' )"

now causes the following:

root@foo:~# openssl req -noout -text -in /etc/apache2/ssl/www.example.com.csr | awk '/X509v3 Subject Alternative Name:/{print;getline;print;}' | tail -n1 | sed -r -e 's/^:space:*//; s/, /'"'$'\n'"'/g'
DNS:example.com'$'
'DNS:www.example.com

what should happen:

root@foo:~# openssl req -noout -text -in /etc/apache2/ssl/www.example.com.csr | awk '/X509v3 Subject Alternative Name:/{print;getline;print;}' | tail -n1 | sed -r -e 's/^:space:*//; s/, /'$'\n''/g'
DNS:example.com
DNS:www.example.com

Originally created by @paulkaweb on GitHub (Nov 1, 2021). Hello, we seem to be having issues creating/renewing certs since your last commits.. the problem seems to stem from this change: ``` - altnames="$( <<<"${altnames}" _sed -e 's/^[[:space:]]*//; s/, /'"'$'\n'"'/g' )" + altnames="$( <<<"${altnames}" _sed -e 's/^[[:space:]]*//; s/, /\'$'\n''/g' )" ``` **now causes the following:** root@foo:~# openssl req -noout -text -in /etc/apache2/ssl/www.example.com.csr | awk '/X509v3 Subject Alternative Name:/{print;getline;print;}' | tail -n1 | sed -r -e 's/^[[:space:]]*//; s/, /'"'$'\n'"'/g' DNS:example.com'$' 'DNS:www.example.com **what should happen:** root@foo:~# openssl req -noout -text -in /etc/apache2/ssl/www.example.com.csr | awk '/X509v3 Subject Alternative Name:/{print;getline;print;}' | tail -n1 | sed -r -e 's/^[[:space:]]*//; s/, /\'$'\n''/g' DNS:example.com DNS:www.example.com
adam closed this issue 2025-12-29 01:27:10 +01:00
Author
Owner

@lukas2511 commented on GitHub (Nov 1, 2021):

Thanks for reporting. I reverted that change and it should hopefully be working again.

@lukas2511 commented on GitHub (Nov 1, 2021): Thanks for reporting. I reverted that change and it should hopefully be working again.
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/dehydrated#555