When HOOK_CHAIN is set, letsencrypt.sh still tries to clean a single challenge in case of an error #53

New Issue

2025-12-29T00:23:34+01:00

adam commented

2025-12-29 00:23:34 +01:00

Originally created by @c-MM on GitHub (Feb 9, 2016).

also add a newline after the Details output:

--- letsencrypt.sh.org  2016-02-09 12:27:39.313301107 +0100
+++ letsencrypt.sh      2016-02-09 12:57:50.419625348 +0100
@@ -221,6 +221,7 @@
     echo >&2
     echo "Details:" >&2
     echo "$out" >&2
+    echo >&2
     exit $res
   fi
 }
@@ -247,7 +248,7 @@
     rm -f "${tempcont}"

     # Wait for hook script to clean the challenge if used
-    if [[ -n "${HOOK}" ]] && [[ -n "${challenge_token:+set}" ]]; then
+    if [[ -n "${HOOK}" ]] && [[ "${HOOK_CHAIN}" != "yes" ]] && [[ -n "${challenge_token:+set}" ]]; then
       ${HOOK} "clean_challenge" '' "${challenge_token}" "${keyauth}" <&4 >&5 2>&6
     fi

root@zoo:~# /etc/letsencrypt/letsencrypt.sh -c
# INFO: Using main config file /etc/letsencrypt/config.sh
Processing mail.******** with alternative names: dump.******** zoo.******** moo.********
 + Signing domains...
 + Generating private key...
 + Generating signing request...
 + Requesting challenge for mail.********...
 + Requesting challenge for dump.********...
 + Requesting challenge for zoo.********...
 + Requesting challenge for moo.********...
 + HOOK: connecting to DNS server cert@foo.********
deploy mail.******** xDKx... VPG8... dump.******** Xhxe... tUAN... zoo.******** 4H0n... p4OS... moo.******** i4Ok... bdDP...
 + DNS: changes commited
 + DNS: master updated
 + DNS: waiting for slaves ........ ok: ********
 + DNS: All slaves are in sync
 + HOOK: disconnected from DNS server
 + Responding to challenge for mail.********...
 + Challenge is valid!
 + Responding to challenge for dump.********...
 + Challenge is valid!
 + Responding to challenge for zoo.********...
 + Challenge is valid!
 + Responding to challenge for moo.********...
 + Challenge is valid!
 + HOOK: connecting to DNS server cert@foo.********
clean mail.******** xDKx... VPG8... dump.******** Xhxe... tUAN... zoo.******** 4H0n... p4OS... moo.******** i4Ok... bdDP...
 + DNS: deleting acme callenges
 + DNS: changes commited
 + HOOK: disconnected from DNS server
 + Requesting certificate...
  + ERROR: An error occurred while sending post-request to https://acme-v01.api.letsencrypt.org/acme/new-cert (Status 429)

Details:
{"type":"urn:acme:error:rateLimited","detail":"Error creating new cert :: Too many certificates already issued for: ********","status":429}
 + HOOK: connecting to DNS server cert@foo.********
clean i4Ok... i4Ok...
 - DNS:  contains illegal chars

Originally created by @c-MM on GitHub (Feb 9, 2016). also add a newline after the Details output: ``` diff --- letsencrypt.sh.org 2016-02-09 12:27:39.313301107 +0100 +++ letsencrypt.sh 2016-02-09 12:57:50.419625348 +0100 @@ -221,6 +221,7 @@ echo >&2 echo "Details:" >&2 echo "$out" >&2 + echo >&2 exit $res fi } @@ -247,7 +248,7 @@ rm -f "${tempcont}" # Wait for hook script to clean the challenge if used - if [[ -n "${HOOK}" ]] && [[ -n "${challenge_token:+set}" ]]; then + if [[ -n "${HOOK}" ]] && [[ "${HOOK_CHAIN}" != "yes" ]] && [[ -n "${challenge_token:+set}" ]]; then ${HOOK} "clean_challenge" '' "${challenge_token}" "${keyauth}" <&4 >&5 2>&6 fi ``` ``` root@zoo:~# /etc/letsencrypt/letsencrypt.sh -c # INFO: Using main config file /etc/letsencrypt/config.sh Processing mail.******** with alternative names: dump.******** zoo.******** moo.******** + Signing domains... + Generating private key... + Generating signing request... + Requesting challenge for mail.********... + Requesting challenge for dump.********... + Requesting challenge for zoo.********... + Requesting challenge for moo.********... + HOOK: connecting to DNS server cert@foo.******** deploy mail.******** xDKx... VPG8... dump.******** Xhxe... tUAN... zoo.******** 4H0n... p4OS... moo.******** i4Ok... bdDP... + DNS: changes commited + DNS: master updated + DNS: waiting for slaves ........ ok: ******** + DNS: All slaves are in sync + HOOK: disconnected from DNS server + Responding to challenge for mail.********... + Challenge is valid! + Responding to challenge for dump.********... + Challenge is valid! + Responding to challenge for zoo.********... + Challenge is valid! + Responding to challenge for moo.********... + Challenge is valid! + HOOK: connecting to DNS server cert@foo.******** clean mail.******** xDKx... VPG8... dump.******** Xhxe... tUAN... zoo.******** 4H0n... p4OS... moo.******** i4Ok... bdDP... + DNS: deleting acme callenges + DNS: changes commited + HOOK: disconnected from DNS server + Requesting certificate... + ERROR: An error occurred while sending post-request to https://acme-v01.api.letsencrypt.org/acme/new-cert (Status 429) Details: {"type":"urn:acme:error:rateLimited","detail":"Error creating new cert :: Too many certificates already issued for: ********","status":429} + HOOK: connecting to DNS server cert@foo.******** clean i4Ok... i4Ok... - DNS: contains illegal chars ```

adam added the bug label 2025-12-29 00:23:34 +01:00

adam closed this issue

2025-12-29 00:23:34 +01:00

adam referenced this issue

2025-12-29 01:28:26 +01:00

[PR #53] [CLOSED] two revoke fixes #683

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/dehydrated#53