mirror of
https://github.com/dehydrated-io/dehydrated.git
synced 2026-01-11 22:30:44 +01:00
newOrder: support notAfter certificate validity #520
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @MEschenbacher on GitHub (Mar 7, 2021).
The ACME protocol supports requesting certificates with a certain validity as optional
notAfterfield in the call to thenewOrderresource: https://tools.ietf.org/html/rfc8555#section-7.4. If unspecified, the issuing CA will decide on the validity.I've been playing around with a private PKI (step-ca) and I'd like to issue shorter certificates if the clients choose to.
Do you think we should add support for this?
@lukas2511 commented on GitHub (Mar 21, 2021):
Sure, sounds good. At least
notAftershould be easy to implement.notBeforewould probably require some restructuring in how cert files are stored so I'd rather avoid that one for now.@MEschenbacher commented on GitHub (Jun 26, 2021):
I'm currently taking a stab at implementing this and I'm struggling to find a portable way of generating the RFC3339 timestamp required as
notAfter.Depending on the solution to the portable timestamp generation, I can think of the following configuration options:
@lukas2511 commented on GitHub (Jun 26, 2021):
I think having it defined in days or hours would be the way to go. Way less parsing necessary and I don't really see the point to have validity to an exact minute. Personally I think having just days defined should be more than good enough.
@lukas2511 commented on GitHub (Jun 26, 2021):
Would be quite nice to have an error if the selected time span isn't possible (e.g. being higher than max age by the CA, or something weird like being <= 0)